Skip to content

Conversation

@RKSimon
Copy link
Collaborator

@RKSimon RKSimon commented Dec 19, 2025

No description provided.

@RKSimon RKSimon enabled auto-merge (squash) December 19, 2025 17:51
@llvmbot
Copy link
Member

llvmbot commented Dec 19, 2025

@llvm/pr-subscribers-backend-x86

Author: Simon Pilgrim (RKSimon)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/173060.diff

1 Files Affected:

  • (modified) llvm/test/CodeGen/X86/vector-shuffle-combining-avx2.ll (+68)
diff --git a/llvm/test/CodeGen/X86/vector-shuffle-combining-avx2.ll b/llvm/test/CodeGen/X86/vector-shuffle-combining-avx2.ll
index 9f48a187f83fd..85a42f73bb959 100644
--- a/llvm/test/CodeGen/X86/vector-shuffle-combining-avx2.ll
+++ b/llvm/test/CodeGen/X86/vector-shuffle-combining-avx2.ll
@@ -1248,3 +1248,71 @@ define <9 x i16> @PR172010(<4 x i64> %a0) {
   %result = shufflevector <16 x i16> zeroinitializer, <16 x i16> %trunc, <9 x i32> <i32 31, i32 18, i32 28, i32 20, i32 7, i32 5, i32 8, i32 4, i32 7>
   ret <9 x i16> %result
 }
+
+define <8 x float> @PR173030(i8 %a0, i16 %a1, i32 %a2) {
+; X86-LABEL: PR173030:
+; X86:       # %bb.0:
+; X86-NEXT:    movl {{[0-9]+}}(%esp), %ecx
+; X86-NEXT:    movl {{[0-9]+}}(%esp), %eax
+; X86-NEXT:    vmovd %ecx, %xmm0
+; X86-NEXT:    # kill: def $cl killed $cl killed $ecx def $ecx
+; X86-NEXT:    incb %cl
+; X86-NEXT:    vpinsrb $1, %ecx, %xmm0, %xmm0
+; X86-NEXT:    movl {{[0-9]+}}(%esp), %ecx
+; X86-NEXT:    vmovd %ecx, %xmm1
+; X86-NEXT:    incl %ecx
+; X86-NEXT:    vpinsrw $1, %ecx, %xmm1, %xmm1
+; X86-NEXT:    vpunpckldq {{.*#+}} xmm0 = xmm0[0],xmm1[0],xmm0[1],xmm1[1]
+; X86-NEXT:    vmovd %eax, %xmm1
+; X86-NEXT:    incl %eax
+; X86-NEXT:    vpinsrd $1, %eax, %xmm1, %xmm1
+; X86-NEXT:    vcvtdq2ps %xmm1, %xmm1
+; X86-NEXT:    vpmovsxbd %xmm0, %ymm0
+; X86-NEXT:    vcvtdq2ps %ymm0, %ymm0
+; X86-NEXT:    vinsertf128 $1, %xmm1, %ymm0, %ymm1
+; X86-NEXT:    vextractf128 $1, %ymm0, %xmm0
+; X86-NEXT:    vunpcklpd {{.*#+}} ymm0 = ymm1[0],ymm0[0],ymm1[2],ymm0[2]
+; X86-NEXT:    vbroadcastss {{.*#+}} ymm1 = [1.0E+0,1.0E+0,1.0E+0,1.0E+0,1.0E+0,1.0E+0,1.0E+0,1.0E+0]
+; X86-NEXT:    vblendps {{.*#+}} ymm0 = ymm0[0,1,2,3,4,5],ymm1[6,7]
+; X86-NEXT:    retl
+;
+; X64-LABEL: PR173030:
+; X64:       # %bb.0:
+; X64-NEXT:    # kill: def $edi killed $edi def $rdi
+; X64-NEXT:    leal 1(%rdi), %eax
+; X64-NEXT:    vmovd %edi, %xmm0
+; X64-NEXT:    vpinsrb $1, %eax, %xmm0, %xmm0
+; X64-NEXT:    vmovd %esi, %xmm1
+; X64-NEXT:    incl %esi
+; X64-NEXT:    vpinsrw $1, %esi, %xmm1, %xmm1
+; X64-NEXT:    vpunpckldq {{.*#+}} xmm0 = xmm0[0],xmm1[0],xmm0[1],xmm1[1]
+; X64-NEXT:    vmovd %edx, %xmm1
+; X64-NEXT:    incl %edx
+; X64-NEXT:    vpinsrd $1, %edx, %xmm1, %xmm1
+; X64-NEXT:    vcvtdq2ps %xmm1, %xmm1
+; X64-NEXT:    vpmovsxbd %xmm0, %ymm0
+; X64-NEXT:    vcvtdq2ps %ymm0, %ymm0
+; X64-NEXT:    vinsertf128 $1, %xmm1, %ymm0, %ymm1
+; X64-NEXT:    vextractf128 $1, %ymm0, %xmm0
+; X64-NEXT:    vunpcklpd {{.*#+}} ymm0 = ymm1[0],ymm0[0],ymm1[2],ymm0[2]
+; X64-NEXT:    vbroadcastss {{.*#+}} ymm1 = [1.0E+0,1.0E+0,1.0E+0,1.0E+0,1.0E+0,1.0E+0,1.0E+0,1.0E+0]
+; X64-NEXT:    vblendps {{.*#+}} ymm0 = ymm0[0,1,2,3,4,5],ymm1[6,7]
+; X64-NEXT:    retq
+  %i = add i8 %a0, 1
+  %i1 = insertelement <2 x i8> poison, i8 %a0, i64 0
+  %i2 = insertelement <2 x i8> %i1, i8 %i, i64 1
+  %i3 = sitofp <2 x i8> %i2 to <2 x float>
+  %i4 = add i16 %a1, 1
+  %i5 = insertelement <2 x i16> poison, i16 %a1, i64 0
+  %i6 = insertelement <2 x i16> %i5, i16 %i4, i64 1
+  %i7 = sitofp <2 x i16> %i6 to <2 x float>
+  %i8 = add i32 %a2, 1
+  %i9 = insertelement <2 x i32> poison, i32 %a2, i64 0
+  %i10 = insertelement <2 x i32> %i9, i32 %i8, i64 1
+  %i11 = sitofp <2 x i32> %i10 to <2 x float>
+  %i12 = shufflevector <2 x float> %i3, <2 x float> %i7, <8 x i32> <i32 0, i32 1, i32 2, i32 3, i32 poison, i32 poison, i32 poison, i32 poison>
+  %i13 = shufflevector <2 x float> %i11, <2 x float> poison, <8 x i32> <i32 0, i32 1, i32 poison, i32 poison, i32 poison, i32 poison, i32 poison, i32 poison>
+  %i14 = shufflevector <8 x float> %i12, <8 x float> %i13, <8 x i32> <i32 0, i32 1, i32 2, i32 3, i32 8, i32 9, i32 poison, i32 poison>
+  %i15 = shufflevector <8 x float> %i14, <8 x float> <float poison, float poison, float poison, float poison, float poison, float poison, float 1.000000e+00, float 1.000000e+00>, <8 x i32> <i32 0, i32 1, i32 2, i32 3, i32 4, i32 5, i32 14, i32 15>
+  ret <8 x float> %i15
+}

@RKSimon RKSimon merged commit b184f00 into llvm:main Dec 19, 2025
11 of 12 checks passed
@RKSimon RKSimon deleted the x86-PR173030-test branch December 19, 2025 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants