Skip to content

Conversation

@macurtis-amd
Copy link
Contributor

Remove unnecessary attributes in test case as requested in post-merge feedback (#172771).

@llvmbot
Copy link
Member

llvmbot commented Dec 19, 2025

@llvm/pr-subscribers-backend-amdgpu

Author: None (macurtis-amd)

Changes

Remove unnecessary attributes in test case as requested in post-merge feedback (#172771).


Full diff: https://github.com/llvm/llvm-project/pull/173071.diff

1 Files Affected:

  • (modified) llvm/test/CodeGen/AMDGPU/promote-alloca-user-mult.ll (+2-6)
diff --git a/llvm/test/CodeGen/AMDGPU/promote-alloca-user-mult.ll b/llvm/test/CodeGen/AMDGPU/promote-alloca-user-mult.ll
index 915e0910a5047..6cf60a5f40f76 100644
--- a/llvm/test/CodeGen/AMDGPU/promote-alloca-user-mult.ll
+++ b/llvm/test/CodeGen/AMDGPU/promote-alloca-user-mult.ll
@@ -7,8 +7,7 @@
 
 %struct.barney = type { i8, double }
 
-; Function Attrs: nofree norecurse noreturn nounwind memory(readwrite, target_mem0: none, target_mem1: none)
-define amdgpu_kernel void @zot() local_unnamed_addr #0 {
+define amdgpu_kernel void @zot() {
 ; CHECK-LABEL: @zot(
 ; CHECK-NEXT:  bb:
 ; CHECK-NEXT:    [[TMP0:%.*]] = call noalias nonnull dereferenceable(64) ptr addrspace(4) @llvm.amdgcn.dispatch.ptr()
@@ -64,7 +63,4 @@ bb2:                                              ; preds = %bb2, %bb
   br label %bb2
 }
 
-declare ptr @hoge() local_unnamed_addr #1
-
-attributes #0 = { nofree norecurse noreturn nounwind memory(readwrite, target_mem0: none, target_mem1: none) "amdgpu-agpr-alloc"="0" "amdgpu-no-cluster-id-x" "amdgpu-no-cluster-id-y" "amdgpu-no-cluster-id-z" "amdgpu-no-completion-action" "amdgpu-no-default-queue" "amdgpu-no-dispatch-id" "amdgpu-no-dispatch-ptr" "amdgpu-no-flat-scratch-init" "amdgpu-no-heap-ptr" "amdgpu-no-hostcall-ptr" "amdgpu-no-implicitarg-ptr" "amdgpu-no-lds-kernel-id" "amdgpu-no-multigrid-sync-arg" "amdgpu-no-queue-ptr" "amdgpu-no-workgroup-id-x" "amdgpu-no-workgroup-id-y" "amdgpu-no-workgroup-id-z" "amdgpu-no-workitem-id-x" "amdgpu-no-workitem-id-y" "amdgpu-no-workitem-id-z" "uniform-work-group-size"="false" }
-attributes #1 = { "uniform-work-group-size"="false" }
+declare ptr @hoge()

@macurtis-amd macurtis-amd merged commit 16a7dba into llvm:main Dec 19, 2025
12 checks passed
@llvm-ci
Copy link
Collaborator

llvm-ci commented Dec 19, 2025

LLVM Buildbot has detected a new failure on builder llvm-clang-x86_64-sie-ubuntu-fast running on sie-linux-worker while building llvm at step 6 "test-build-unified-tree-check-all".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/144/builds/42713

Here is the relevant piece of the build log for the reference
Step 6 (test-build-unified-tree-check-all) failure: test (failure)
******************** TEST 'Clang :: Preprocessor/c99-6_10_3_4_p6.c' FAILED ********************
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 3
/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/bin/clang -cc1 -internal-isystem /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/lib/clang/22/include -nostdsysteminc -E /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/clang/test/Preprocessor/c99-6_10_3_4_p6.c | /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/bin/FileCheck -strict-whitespace /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/clang/test/Preprocessor/c99-6_10_3_4_p6.c
# executed command: /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/bin/clang -cc1 -internal-isystem /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/lib/clang/22/include -nostdsysteminc -E /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/clang/test/Preprocessor/c99-6_10_3_4_p6.c
# .---command stderr------------
# | /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/clang/test/Preprocessor/c99-6_10_3_4_p6.c:7:57: warning: backslash and newline separated by space [-Wbackslash-newline-escape]
# |     7 | #define debug(s, t) printf("x" # s "= %d, x" # t "= s" \ 
# |       |                                                         ^
# | 1 warning generated.
# `-----------------------------
# executed command: /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/bin/FileCheck -strict-whitespace /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/clang/test/Preprocessor/c99-6_10_3_4_p6.c
# .---command stderr------------
# | �[1m/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/clang/test/Preprocessor/c99-6_10_3_4_p6.c:24:11: �[0m�[0;1;31merror: �[0m�[1mCHECK: expected string not found in input
�[0m# | �[1m�[0m// CHECK: include "vers2.h"
# | �[0;1;32m          ^
�[0m# | �[0;1;32m�[0m�[1m<stdin>:10:62: �[0m�[0;1;30mnote: �[0m�[1mscanning from here
�[0m# | �[1m�[0mfputs("strncmp(\"abc\\0d\" \"abc\", '\\4') == 0" ": @\n", s);
# | �[0;1;32m                                                             ^
�[0m# | �[0;1;32m�[0m�[1m<stdin>:12:1: �[0m�[0;1;30mnote: �[0m�[1mpossible intended match here
�[0m# | �[1m�[0minclude "vers2 .h"
# | �[0;1;32m^
�[0m# | �[0;1;32m�[0m
# | Input file: <stdin>
# | Check file: /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/clang/test/Preprocessor/c99-6_10_3_4_p6.c
# | 
# | -dump-input=help explains the following input dump.
# | 
# | Input was:
# | <<<<<<
# | �[1m�[0m�[0;1;30m            1: �[0m�[1m�[0;1;46m# 1 "/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/clang/test/Preprocessor/c99-6_10_3_4_p6.c" �[0m
# | �[0;1;30m            2: �[0m�[1m�[0;1;46m# 1 "<built-in>" 1 �[0m
# | �[0;1;30m            3: �[0m�[1m�[0;1;46m# 1 "<built-in>" 3 �[0m
# | �[0;1;30m            4: �[0m�[1m�[0;1;46m# 389 "<built-in>" 3 �[0m
# | �[0;1;30m            5: �[0m�[1m�[0;1;46m# 1 "<command line>" 1 �[0m
# | �[0;1;30m            6: �[0m�[1m�[0;1;46m# 1 "<built-in>" 2 �[0m
# | �[0;1;30m            7: �[0m�[1m�[0;1;46m# 1 "/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/clang/test/Preprocessor/c99-6_10_3_4_p6.c" 2 �[0m
# | �[0;1;30m            8: �[0m�[1m�[0;1;46m# 14 "/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/clang/test/Preprocessor/c99-6_10_3_4_p6.c" �[0m
# | �[0;1;30m            9: �[0m�[1m�[0;1;46m�[0mprintf("x" "1" "= %d, x" "2" "= s" x1, x2);�[0;1;46m �[0m
# | �[0;1;32mcheck:22       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
�[0m# | �[0;1;32m�[0m�[0;1;30m           10: �[0m�[1m�[0;1;46m�[0mfputs("strncmp(\"abc\\0d\" \"abc\", '\\4') == 0" ": @\n", s);�[0;1;46m �[0m
# | �[0;1;32mcheck:23       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
�[0m# | �[0;1;32m�[0m�[0;1;31mcheck:24'0                                                                  X error: no match found
�[0m# | �[0;1;31m�[0m�[0;1;30m           11: �[0m�[1m�[0;1;46m �[0m
# | �[0;1;31mcheck:24'0     ~
�[0m# | �[0;1;31m�[0m�[0;1;30m           12: �[0m�[1m�[0;1;46minclude "vers2 .h" �[0m
# | �[0;1;31mcheck:24'0     ~~~~~~~~~~~~~~~~~~~
...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants