[offload][lit] Fix requires.c after 'not' behavior change #174499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nick Sarnie <nick.sarnie@intel.com>
Member
|
@llvm/pr-subscribers-offload Author: Nick Sarnie (sarnex) Changes
Full diff: https://github.com/llvm/llvm-project/pull/174499.diff 1 Files Affected:
diff --git a/offload/test/offloading/requires.c b/offload/test/offloading/requires.c
index 249c478215d42..2afbbcbde6155 100644
--- a/offload/test/offloading/requires.c
+++ b/offload/test/offloading/requires.c
@@ -1,6 +1,6 @@
// clang-format off
// RUN: %libomptarget-compile-generic -DREQ=1 && %libomptarget-run-generic 2>&1 | %fcheck-generic -check-prefix=GOOD
-// RUN: %libomptarget-compile-generic -DREQ=2 && not %libomptarget-run-generic 2>&1 | %fcheck-generic -check-prefix=BAD
+// RUN: %libomptarget-compile-generic -DREQ=2 && not --crash %libomptarget-run-generic 2>&1 | %fcheck-generic -check-prefix=BAD
// clang-format on
/*
|
Contributor
boomanaiden154
left a comment
boomanaiden154
left a comment
There was a problem hiding this comment.
Does this not crash without assertions?
Member
Author
|
Really good question, one sec |
Member
Author
|
The behavior is the same with and without assertions, the test throws SIGABRT and returns signal 134. The test passes with |
boomanaiden154
approved these changes
Jan 5, 2026
Contributor
boomanaiden154
left a comment
boomanaiden154
left a comment
There was a problem hiding this comment.
Thanks for the confirmation.
Member
Author
|
Thanks for the feedback! |
mahesh-attarde
pushed a commit
to mahesh-attarde/llvm-project
that referenced
this pull request
Jan 6, 2026
`not` behavior change in llvm#174298 requires `--crash` passed now. Signed-off-by: Nick Sarnie <nick.sarnie@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
notbehavior change in #174298 requires--crashpassed now.