Conversation
There are currently no other tests checking `half` so I am unsure how well supported the type is, but the patch here resolves the op tests. Fixes the (unlisted) Lanai portion of llvm#97975 Fixes the (unlisted) Lanai portion of llvm#97981
Contributor
|
I think at this point it might make more sense to make softPromoteHalfType return true by default and instead opt-out the targets where this might require further work (IIRC amdgpu had some test changes)? |
Contributor
Author
|
I was planning to follow up with that, but figured that it is worth swapping the remaining targets first since some need more specific updates, and in case of problems changing the default. Would you prefer me to drop this patchset and just do that? If it's fine to apply these first, I'll mark this one through #175141 ready to review (still need to figure something out with xcore) |
Contributor
|
I'm okay with doing these first. |
Contributor
Author
|
Alright. I figure you'll wind up reviewing so these should be all set: |
Priyanshu3820
pushed a commit
to Priyanshu3820/llvm-project
that referenced
this pull request
Jan 18, 2026
There are currently no other tests checking `half` so I am unsure how well supported the type is, but the patch here resolves the op tests. Fixes the (unlisted) Lanai portion of llvm#97975 Fixes the (unlisted) Lanai portion of llvm#97981
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are currently no other tests checking
halfso I am unsure how well supported the type is, but the patch here resolves the op tests.Fixes the (unlisted) Lanai portion of #97975
Fixes the (unlisted) Lanai portion of #97981