[lldb] skip TestHiddenFrameMarkers test on Windows #176736
Closed
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@llvm/pr-subscribers-lldb Author: Charles Zablit (charles-zablit) ChangesThis patch deactivates the #167550 introduced a new marker in front of hidden frames in the lldb backtrace printer. Hidden frames do not seem to be working on Windows. Full diff: https://github.com/llvm/llvm-project/pull/176736.diff 1 Files Affected:
diff --git a/lldb/test/API/terminal/hidden_frame_markers/TestHiddenFrameMarkers.py b/lldb/test/API/terminal/hidden_frame_markers/TestHiddenFrameMarkers.py
index 178d97fce17c2..c7f62861d65b5 100644
--- a/lldb/test/API/terminal/hidden_frame_markers/TestHiddenFrameMarkers.py
+++ b/lldb/test/API/terminal/hidden_frame_markers/TestHiddenFrameMarkers.py
@@ -9,6 +9,7 @@
class HiddenFrameMarkerTest(TestBase):
+ @skipIfWindows
@unicode_test
def test_hidden_frame_markers(self):
"""Test that hidden frame markers are rendered in backtraces"""
@@ -51,7 +52,8 @@ def test_hidden_frame_markers(self):
],
)
- def test_hidden_frame_markers(self):
+ @skipIfWindows
+ def test_hidden_frame_markers_setting_deactivation(self):
"""
Test that hidden frame markers are not rendered in backtraces when
mark-hidden-frames is set to false
|
🐧 Linux x64 Test Results
Failed Tests(click on a test name to see its output) lldb-apilldb-api.terminal/hidden_frame_markers/TestHiddenFrameMarkers.pyIf these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the |
Contributor
|
It looks more like a |
Member
|
FWIW, to keep the tests (which in any way rely on a specific STL) as hermetic as possible we usually don't include the STL headers unless we're specifically testing them for, e.g., data-formatters, frame recognizers. You're not really testing the frame recognizers themselves, but just the fact that hidden frames get marked. We might be able to use scripted frame providers to artificially set up a scenario where some of the frames are hidden (see It would be unfortunate to lose coverage for something that is possibly system dependent just because a user/buildbot didn't happen to build libc++ locally (this is only required on Darwin, so can definitely happen). |
Contributor
Author
|
I will try that, thanks! I ended up reverting the patch in the meantime until I come up with a proper fix for the test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch deactivates the
TestHiddenFrameMarkerstest on Windows.#167550 introduced a new marker in front of hidden frames in the lldb backtrace printer. Hidden frames do not seem to be working on Windows.
#176738 is the tracking issue for the hidden frames on Windows.