[NFC][Clang][UnsafeBufferUsage] Simplify libc function matchers. #178985
+3
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
clang
Member
|
@llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-analysis Author: Rohan Jacob-Rao (rohanjr) ChangesFull diff: https://github.com/llvm/llvm-project/pull/178985.diff 1 Files Affected:
diff --git a/clang/lib/Analysis/UnsafeBufferUsage.cpp b/clang/lib/Analysis/UnsafeBufferUsage.cpp
index 761aedda7eacf..761cdccc65d50 100644
--- a/clang/lib/Analysis/UnsafeBufferUsage.cpp
+++ b/clang/lib/Analysis/UnsafeBufferUsage.cpp
@@ -1194,9 +1194,7 @@ static bool isUnsafeVaListPrintfFunc(const FunctionDecl &Node) {
StringRef Name = LibcFunNamePrefixSuffixParser().matchName(
II->getName(), Node.getBuiltinID());
- if (!Name.ends_with("printf"))
- return false; // neither printf nor scanf
- return Name.starts_with("v");
+ return Name.starts_with("v") && Name.ends_with("printf");
}
// Matches a call to one of the `sprintf` functions as they are always unsafe
@@ -1210,16 +1208,7 @@ static bool isUnsafeSprintfFunc(const FunctionDecl &Node) {
StringRef Name = LibcFunNamePrefixSuffixParser().matchName(
II->getName(), Node.getBuiltinID());
- if (!Name.ends_with("printf") ||
- // Let `isUnsafeVaListPrintfFunc` check for cases with va-list:
- Name.starts_with("v"))
- return false;
-
- StringRef Prefix = Name.drop_back(6);
-
- if (Prefix.ends_with("w"))
- Prefix = Prefix.drop_back(1);
- return Prefix == "s";
+ return Name == "sprintf" || Name == "swprintf";
}
// Match function declarations of `printf`, `fprintf`, `snprintf` and their wide
@@ -1234,7 +1223,7 @@ static bool isNormalPrintfFunc(const FunctionDecl &Node) {
StringRef Name = LibcFunNamePrefixSuffixParser().matchName(
II->getName(), Node.getBuiltinID());
- if (!Name.ends_with("printf") || Name.starts_with("v"))
+ if (!Name.ends_with("printf"))
return false;
StringRef Prefix = Name.drop_back(6);
|
Contributor
Author
|
@fmayer for review |
🐧 Linux x64 Test Results
Failed Tests(click on a test name to see its output) lldb-apilldb-api.lang/c/calling-conventions/TestCCallingConventions.pylldb-api.lang/cpp/thread_local/TestThreadLocal.pyIf these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the |
Thibault-Monnier
approved these changes
Jan 31, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.