[NFC] Fix typos 'bicast' -> 'bitcast'#180890
Merged
Conversation
Member
|
@llvm/pr-subscribers-llvm-transforms Author: Wang Yaduo (MouseSplinter) ChangesFix typos bicast -> bitcast. Full diff: https://github.com/llvm/llvm-project/pull/180890.diff 2 Files Affected:
diff --git a/llvm/lib/CodeGen/CodeGenPrepare.cpp b/llvm/lib/CodeGen/CodeGenPrepare.cpp
index 65b5965d99c18..e79f911a6fb02 100644
--- a/llvm/lib/CodeGen/CodeGenPrepare.cpp
+++ b/llvm/lib/CodeGen/CodeGenPrepare.cpp
@@ -6972,7 +6972,7 @@ bool CodeGenPrepare::optimizePhiType(
SmallPtrSet<Instruction *, 4> Defs;
SmallPtrSet<Instruction *, 4> Uses;
// This works by adding extra bitcasts between load/stores and removing
- // existing bicasts. If we have a phi(bitcast(load)) or a store(bitcast(phi))
+ // existing bitcasts. If we have a phi(bitcast(load)) or a store(bitcast(phi))
// we can get in the situation where we remove a bitcast in one iteration
// just to add it again in the next. We need to ensure that at least one
// bitcast we remove are anchored to something that will not change back.
diff --git a/llvm/lib/Transforms/Scalar/InferAddressSpaces.cpp b/llvm/lib/Transforms/Scalar/InferAddressSpaces.cpp
index 352a1b331001a..5a66b87598cb9 100644
--- a/llvm/lib/Transforms/Scalar/InferAddressSpaces.cpp
+++ b/llvm/lib/Transforms/Scalar/InferAddressSpaces.cpp
@@ -270,7 +270,7 @@ static Type *getPtrOrVecOfPtrsWithNewAS(Type *Ty, unsigned NewAddrSpace) {
return Ty->getWithNewType(NPT);
}
-// Check whether that's no-op pointer bicast using a pair of
+// Check whether that's no-op pointer bitcast using a pair of
// `ptrtoint`/`inttoptr` due to the missing no-op pointer bitcast over
// different address spaces.
static bool isNoopPtrIntCastPair(const Operator *I2P, const DataLayout &DL,
|
MouseSplinter
force-pushed
the
fix_typo_bicast
branch
from
f38144b to
f321f1c
Compare
boomanaiden154
approved these changes
Feb 11, 2026
Xeonacid
approved these changes
Feb 15, 2026
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/141/builds/15442 Here is the relevant piece of the build log for the reference |
manasij7479
pushed a commit
to manasij7479/llvm-project
that referenced
this pull request
Feb 18, 2026
Fix typos bicast -> bitcast. I find this when I'm resovling a codegen prepare optimazation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix typos bicast -> bitcast. I find this when I'm resovling a codegen prepare optimazation.