[NFC][docs]: fix a couple typos in Statistic.h#185657
[NFC][docs]: fix a couple typos in Statistic.h#185657
Conversation
|
Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers. If you have further questions, they may be answered by the LLVM GitHub User Guide. You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums. |
|
@llvm/pr-subscribers-llvm-adt Author: Jamie (jamieQ) ChangesNoticed a couple minor typos when reading through this file. Full diff: https://github.com/llvm/llvm-project/pull/185657.diff 1 Files Affected:
diff --git a/llvm/include/llvm/ADT/Statistic.h b/llvm/include/llvm/ADT/Statistic.h
index 75d608beb0134..19c04b1f09f22 100644
--- a/llvm/include/llvm/ADT/Statistic.h
+++ b/llvm/include/llvm/ADT/Statistic.h
@@ -202,7 +202,7 @@ LLVM_ABI void PrintStatisticsJSON(raw_ostream &OS);
/// statistics without needing to parse JSON.
///
/// This function does not prevent statistics being updated by other threads
-/// during it's execution. It will return the value at the point that it is
+/// during its execution. It will return the value at the point that it is
/// read. However, it will prevent new statistics from registering until it
/// completes.
LLVM_ABI std::vector<std::pair<StringRef, uint64_t>> GetStatistics();
@@ -212,8 +212,8 @@ LLVM_ABI std::vector<std::pair<StringRef, uint64_t>> GetStatistics();
///
/// When this function begins to call destructors prior to returning, all
/// statistics will be zero and unregistered. However, that might not remain the
-/// case by the time this function finishes returning. Whether update from other
-/// threads are lost or merely deferred until during the function return is
+/// case by the time this function finishes returning. Whether updates from
+/// other threads are lost or merely deferred until the function returns is
/// timing sensitive.
///
/// Callers who intend to use this to measure statistics for a single
|
|
|
|
@jamieQ we can land once you fix the public email issue |
@kuhar thank you – I read the linked forum discussion about this (though admittedly did not entirely follow all of it), and attempted to remedy the problem by changing the email associated with the commit locally and force-pushing this branch. Is there something more than that which I need to do? |
|
This is a github setting, not a git thing |
|
Ah, I see. Well I guess I don't really want to change my github settings just for this, so I suppose I'll just close the PR. Sorry to waste your time. |
Noticed a couple minor typos when reading through this file.