[clang-doc] Support deep copy between arenas for merging#190055
Merged
[clang-doc] Support deep copy between arenas for merging#190055
Conversation
This was referenced Apr 1, 2026
Contributor
Author
Member
|
@llvm/pr-subscribers-clang-tools-extra Author: Paul Kirth (ilovepi) ChangesUpcoming changes to the merge step will necessitate that we clear the On the performance front, we reclaim about 2% of the overhead, bringing
Full diff: https://github.com/llvm/llvm-project/pull/190055.diff 2 Files Affected:
diff --git a/clang-tools-extra/clang-doc/Representation.cpp b/clang-tools-extra/clang-doc/Representation.cpp
index b4a1dd0af0f32..718a466eaeb8a 100644
--- a/clang-tools-extra/clang-doc/Representation.cpp
+++ b/clang-tools-extra/clang-doc/Representation.cpp
@@ -115,7 +115,8 @@ static void reduceChildren(llvm::simple_ilist<T> &Children,
auto It = llvm::find_if(
Children, [&](const T &C) { return C.USR == ChildToMerge->USR; });
if (It == Children.end()) {
- Children.push_back(*ChildToMerge);
+ T *NewChild = allocatePtr<T>(PersistentArena, std::move(*ChildToMerge));
+ Children.push_back(*NewChild);
} else {
It->merge(std::move(*ChildToMerge));
}
@@ -124,11 +125,14 @@ static void reduceChildren(llvm::simple_ilist<T> &Children,
template <typename Container>
static void mergeUnkeyed(Container &Target, Container &&Source) {
+ using T = typename Container::value_type;
while (!Source.empty()) {
auto &Item = Source.front();
Source.pop_front();
- if (llvm::none_of(Target, [&](const auto &E) { return E == Item; }))
- Target.push_back(Item);
+ if (llvm::none_of(Target, [&](const auto &E) { return E == Item; })) {
+ T *NewItem = allocatePtr<T>(PersistentArena, std::move(Item));
+ Target.push_back(*NewItem);
+ }
}
}
@@ -162,6 +166,20 @@ llvm::Expected<OwnedPtr<Info>> mergeInfos(OwningPtrArray<Info> &Values) {
llvm_unreachable("unhandled enumerator");
}
+TemplateSpecializationInfo::TemplateSpecializationInfo(
+ const TemplateSpecializationInfo &Other, llvm::BumpPtrAllocator &Arena)
+ : SpecializationOf(Other.SpecializationOf) {
+ Params = allocateArray(Other.Params, Arena);
+}
+
+TemplateInfo::TemplateInfo(const TemplateInfo &Other,
+ llvm::BumpPtrAllocator &Arena) {
+ Params = allocateArray(Other.Params, Arena);
+ if (Other.Specialization)
+ Specialization = TemplateSpecializationInfo(*Other.Specialization, Arena);
+ Constraints = allocateArray(Other.Constraints, Arena);
+}
+
bool CommentInfo::operator==(const CommentInfo &Other) const {
auto FirstCI = std::tie(Kind, Text, Name, Direction, ParamName, CloseName,
SelfClosing, Explicit, AttrKeys, AttrValues, Args);
@@ -197,6 +215,28 @@ bool CommentInfo::operator<(const CommentInfo &Other) const {
return false;
}
+CommentInfo::CommentInfo(const CommentInfo &Other,
+ llvm::BumpPtrAllocator &Arena) {
+ Kind = Other.Kind;
+ Direction = Other.Direction;
+ Name = Other.Name;
+ ParamName = Other.ParamName;
+ CloseName = Other.CloseName;
+ SelfClosing = Other.SelfClosing;
+ Explicit = Other.Explicit;
+ Text = Other.Text;
+ AttrKeys = allocateArray(Other.AttrKeys, Arena);
+ AttrValues = allocateArray(Other.AttrValues, Arena);
+ Args = allocateArray(Other.Args, Arena);
+ if (!Other.Children.empty()) {
+ CommentInfo *NewArray = Arena.Allocate<CommentInfo>(Other.Children.size());
+ for (size_t i = 0; i < Other.Children.size(); ++i) {
+ new (NewArray + i) CommentInfo(Other.Children[i], Arena);
+ }
+ Children = llvm::ArrayRef<CommentInfo>(NewArray, Other.Children.size());
+ }
+}
+
static llvm::SmallString<64>
calculateRelativeFilePath(const InfoType &Type, const StringRef &Path,
const StringRef &Name, const StringRef &CurrentPath) {
@@ -267,6 +307,31 @@ void FriendInfo::merge(FriendInfo &&Other) {
SymbolInfo::merge(std::move(Other));
}
+FriendInfo::FriendInfo(const FriendInfo &Other, llvm::BumpPtrAllocator &Arena)
+ : SymbolInfo(Other, Arena) {
+ Ref = Other.Ref;
+ if (Other.Template)
+ Template.emplace(*Other.Template, Arena);
+ if (Other.ReturnType)
+ ReturnType = Other.ReturnType;
+ if (!Other.Params.empty())
+ Params = allocateArray(Other.Params, Arena);
+ IsClass = Other.IsClass;
+}
+
+Info::Info(const Info &Other, llvm::BumpPtrAllocator &Arena)
+ : Path(Other.Path), Name(Other.Name),
+ DocumentationFileName(Other.DocumentationFileName), USR(Other.USR),
+ ParentUSR(Other.ParentUSR), IT(Other.IT) {
+ Namespace = allocateArray(Other.Namespace, Arena);
+ if (!Other.Description.empty()) {
+ for (const auto &Desc : Other.Description) {
+ CommentInfo *NewDesc = allocatePtr<CommentInfo>(Arena, Desc, Arena);
+ Description.push_back(*NewDesc);
+ }
+ }
+}
+
void Info::mergeBase(Info &&Other) {
assert(mergeable(Other));
if (USR == EmptySID)
@@ -289,6 +354,17 @@ bool Info::mergeable(const Info &Other) {
return IT == Other.IT && USR == Other.USR;
}
+SymbolInfo::SymbolInfo(const SymbolInfo &Other, llvm::BumpPtrAllocator &Arena)
+ : Info(Other, Arena), DefLoc(Other.DefLoc), MangledName(Other.MangledName),
+ IsStatic(Other.IsStatic) {
+ if (!Other.Loc.empty()) {
+ for (const auto &L : Other.Loc) {
+ Location *NewL = allocatePtr<Location>(Arena, L);
+ Loc.push_back(*NewL);
+ }
+ }
+}
+
void SymbolInfo::merge(SymbolInfo &&Other) {
assert(mergeable(Other));
if (!DefLoc)
@@ -319,21 +395,47 @@ void NamespaceInfo::merge(NamespaceInfo &&Other) {
RecordInfo::RecordInfo(SymbolID USR, StringRef Name, StringRef Path)
: SymbolInfo(InfoType::IT_record, USR, Name, Path) {}
+// FIXME: This constructor is currently unsafe for cross-arena copies of
+// populated records. Because a default copy of ScopeChildren will shallow-copy
+// the intrusive pointers, leading to a use-after-free when the TransientArena
+// is reset. Subsequent patches will address this by deep-copying children
+// individually via reduceChildren.
+RecordInfo::RecordInfo(const RecordInfo &Other, llvm::BumpPtrAllocator &Arena)
+ : SymbolInfo(Other, Arena), TagType(Other.TagType),
+ IsTypeDef(Other.IsTypeDef) {
+ Members = deepCopyArray(Other.Members, Arena);
+ Parents = allocateArray(Other.Parents, Arena);
+ VirtualParents = allocateArray(Other.VirtualParents, Arena);
+ Bases = deepCopyArray(Other.Bases, Arena);
+ Friends = deepCopyArray(Other.Friends, Arena);
+}
+
+MemberTypeInfo::MemberTypeInfo(const MemberTypeInfo &Other,
+ llvm::BumpPtrAllocator &Arena)
+ : FieldTypeInfo(Other), Access(Other.Access), IsStatic(Other.IsStatic) {
+ if (!Other.Description.empty()) {
+ for (const auto &Desc : Other.Description) {
+ CommentInfo *NewDesc = allocatePtr<CommentInfo>(Arena, Desc, Arena);
+ Description.push_back(*NewDesc);
+ }
+ }
+}
+
void RecordInfo::merge(RecordInfo &&Other) {
assert(mergeable(Other));
if (!llvm::to_underlying(TagType))
TagType = Other.TagType;
IsTypeDef = IsTypeDef || Other.IsTypeDef;
- if (Members.empty())
- Members = std::move(Other.Members);
- if (Bases.empty())
- Bases = std::move(Other.Bases);
- if (Parents.empty())
- Parents = std::move(Other.Parents);
- if (VirtualParents.empty())
- VirtualParents = std::move(Other.VirtualParents);
- if (Friends.empty())
- Friends = std::move(Other.Friends);
+ if (Members.empty() && !Other.Members.empty())
+ Members = deepCopyArray(Other.Members, PersistentArena);
+ if (Bases.empty() && !Other.Bases.empty())
+ Bases = deepCopyArray(Other.Bases, PersistentArena);
+ if (Parents.empty() && !Other.Parents.empty())
+ Parents = allocateArray(Other.Parents, PersistentArena);
+ if (VirtualParents.empty() && !Other.VirtualParents.empty())
+ VirtualParents = allocateArray(Other.VirtualParents, PersistentArena);
+ if (Friends.empty() && !Other.Friends.empty())
+ Friends = deepCopyArray(Other.Friends, PersistentArena);
// Reduce children if necessary.
reduceChildren(Children.Records, std::move(Other.Children.Records));
reduceChildren(Children.Functions, std::move(Other.Children.Functions));
@@ -344,12 +446,23 @@ void RecordInfo::merge(RecordInfo &&Other) {
Template = Other.Template;
}
+EnumValueInfo::EnumValueInfo(const EnumValueInfo &Other,
+ llvm::BumpPtrAllocator &Arena)
+ : Name(Other.Name), Value(Other.Value), ValueExpr(Other.ValueExpr) {
+ if (!Other.Description.empty()) {
+ for (const auto &Desc : Other.Description) {
+ CommentInfo *NewDesc = allocatePtr<CommentInfo>(Arena, Desc, Arena);
+ Description.push_back(*NewDesc);
+ }
+ }
+}
+
void EnumInfo::merge(EnumInfo &&Other) {
assert(mergeable(Other));
if (!Scoped)
Scoped = Other.Scoped;
- if (Members.empty())
- Members = std::move(Other.Members);
+ if (Members.empty() && !Other.Members.empty())
+ Members = deepCopyArray(Other.Members, PersistentArena);
SymbolInfo::merge(std::move(Other));
}
@@ -363,8 +476,8 @@ void FunctionInfo::merge(FunctionInfo &&Other) {
ReturnType = std::move(Other.ReturnType);
if (Parent.USR == EmptySID && Parent.Name == "")
Parent = std::move(Other.Parent);
- if (Params.empty())
- Params = std::move(Other.Params);
+ if (Params.empty() && !Other.Params.empty())
+ Params = allocateArray(Other.Params, PersistentArena);
SymbolInfo::merge(std::move(Other));
if (!Template)
Template = Other.Template;
@@ -387,10 +500,11 @@ void ConceptInfo::merge(ConceptInfo &&Other) {
IsType = Other.IsType;
if (ConstraintExpression.empty())
ConstraintExpression = std::move(Other.ConstraintExpression);
- if (Template.Constraints.empty())
- Template.Constraints = std::move(Other.Template.Constraints);
- if (Template.Params.empty())
- Template.Params = std::move(Other.Template.Params);
+ if (Template.Constraints.empty() && !Other.Template.Constraints.empty())
+ Template.Constraints =
+ allocateArray(Other.Template.Constraints, PersistentArena);
+ if (Template.Params.empty() && !Other.Template.Params.empty())
+ Template.Params = allocateArray(Other.Template.Params, PersistentArena);
SymbolInfo::merge(std::move(Other));
}
@@ -405,6 +519,11 @@ void VarInfo::merge(VarInfo &&Other) {
BaseRecordInfo::BaseRecordInfo() : RecordInfo() {}
+BaseRecordInfo::BaseRecordInfo(const BaseRecordInfo &Other,
+ llvm::BumpPtrAllocator &Arena)
+ : RecordInfo(Other, Arena), Access(Other.Access),
+ IsVirtual(Other.IsVirtual), IsParent(Other.IsParent) {}
+
BaseRecordInfo::BaseRecordInfo(SymbolID USR, StringRef Name, StringRef Path,
bool IsVirtual, AccessSpecifier Access,
bool IsParent)
diff --git a/clang-tools-extra/clang-doc/Representation.h b/clang-tools-extra/clang-doc/Representation.h
index f73ab751b7ba3..0a6fbd501d5e5 100644
--- a/clang-tools-extra/clang-doc/Representation.h
+++ b/clang-tools-extra/clang-doc/Representation.h
@@ -91,6 +91,18 @@ llvm::ArrayRef<T> allocateArray(llvm::ArrayRef<T> V,
return llvm::ArrayRef<T>(Allocated, V.size());
}
+template <typename T>
+llvm::ArrayRef<T> deepCopyArray(llvm::ArrayRef<T> V,
+ llvm::BumpPtrAllocator &Alloc) {
+ if (V.empty())
+ return llvm::ArrayRef<T>();
+ T *Allocated = (T *)Alloc.Allocate<T>(V.size());
+ for (size_t i = 0; i < V.size(); ++i) {
+ new (Allocated + i) T(V[i], Alloc);
+ }
+ return llvm::ArrayRef<T>(Allocated, V.size());
+}
+
// An abstraction for owned pointers. Initially mapped to OwnedPtr,
// to be eventually transitioned to bare pointers in an arena.
template <typename T> using OwnedPtr = T *;
@@ -180,6 +192,7 @@ struct CommentInfo : public llvm::ilist_node<CommentInfo> {
CommentInfo() = default;
CommentInfo(const CommentInfo &Other) = default;
CommentInfo &operator=(const CommentInfo &Other) = default;
+ CommentInfo(const CommentInfo &Other, llvm::BumpPtrAllocator &Arena);
CommentInfo(CommentInfo &&Other) = default;
CommentInfo &operator=(CommentInfo &&Other) = default;
@@ -349,6 +362,10 @@ struct TemplateParamInfo {
};
struct TemplateSpecializationInfo {
+ TemplateSpecializationInfo() = default;
+ TemplateSpecializationInfo(const TemplateSpecializationInfo &Other,
+ llvm::BumpPtrAllocator &Arena);
+
// Indicates the declaration that this specializes.
SymbolID SpecializationOf;
@@ -368,6 +385,9 @@ struct ConstraintInfo {
// Records the template information for a struct or function that is a template
// or an explicit template specialization.
struct TemplateInfo {
+ TemplateInfo() = default;
+ TemplateInfo(const TemplateInfo &Other, llvm::BumpPtrAllocator &Arena);
+
// May be empty for non-partial specializations.
llvm::ArrayRef<TemplateParamInfo> Params;
@@ -399,6 +419,7 @@ struct FieldTypeInfo : public TypeInfo {
// Info for member types.
struct MemberTypeInfo : public FieldTypeInfo {
MemberTypeInfo() = default;
+ MemberTypeInfo(const MemberTypeInfo &Other, llvm::BumpPtrAllocator &Arena);
MemberTypeInfo(const TypeInfo &TI, StringRef Name, AccessSpecifier Access,
bool IsStatic = false)
: FieldTypeInfo(TI, Name), Access(Access), IsStatic(IsStatic) {}
@@ -455,6 +476,7 @@ struct Info {
StringRef Name = StringRef(), StringRef Path = StringRef())
: Path(internString(Path)), Name(internString(Name)), USR(USR), IT(IT) {}
+ Info(const Info &Other, llvm::BumpPtrAllocator &Arena);
Info(const Info &Other) = delete;
Info(Info &&Other) = default;
@@ -517,6 +539,8 @@ struct SymbolInfo : public Info {
StringRef Name = StringRef(), StringRef Path = StringRef())
: Info(IT, USR, Name, Path) {}
+ SymbolInfo(const SymbolInfo &Other, llvm::BumpPtrAllocator &Arena);
+
void merge(SymbolInfo &&I);
bool operator<(const SymbolInfo &Other) const {
@@ -546,6 +570,7 @@ struct FriendInfo : public SymbolInfo, public llvm::ilist_node<FriendInfo> {
FriendInfo(const InfoType IT, const SymbolID &USR,
const StringRef Name = StringRef())
: SymbolInfo(IT, USR, Name) {}
+ FriendInfo(const FriendInfo &Other, llvm::BumpPtrAllocator &Arena);
bool mergeable(const FriendInfo &Other);
void merge(FriendInfo &&Other);
@@ -597,6 +622,8 @@ struct RecordInfo : public SymbolInfo {
RecordInfo(SymbolID USR = SymbolID(), StringRef Name = StringRef(),
StringRef Path = StringRef());
+ RecordInfo(const RecordInfo &Other, llvm::BumpPtrAllocator &Arena);
+
void merge(RecordInfo &&I);
// Type of this record (struct, class, union, interface).
@@ -652,6 +679,7 @@ struct TypedefInfo : public SymbolInfo, public llvm::ilist_node<TypedefInfo> {
struct BaseRecordInfo : public RecordInfo,
public llvm::ilist_node<BaseRecordInfo> {
BaseRecordInfo();
+ BaseRecordInfo(const BaseRecordInfo &Other, llvm::BumpPtrAllocator &Arena);
BaseRecordInfo(SymbolID USR, StringRef Name, StringRef Path, bool IsVirtual,
AccessSpecifier Access, bool IsParent);
@@ -671,6 +699,8 @@ struct EnumValueInfo {
: Name(internString(Name)), Value(internString(Value)),
ValueExpr(internString(ValueExpr)) {}
+ EnumValueInfo(const EnumValueInfo &Other, llvm::BumpPtrAllocator &Arena);
+
bool operator==(const EnumValueInfo &Other) const {
return std::tie(Name, Value, ValueExpr) ==
std::tie(Other.Name, Other.Value, Other.ValueExpr);
|
ilovepi
force-pushed
the
users/ilovepi/new-arenas-11
branch
from
707229c to
cdcd80f
Compare
ilovepi
force-pushed
the
users/ilovepi/new-arenas-12
branch
from
93bdfe2 to
3146d00
Compare
This was referenced Apr 2, 2026
ilovepi
force-pushed
the
users/ilovepi/new-arenas-11
branch
from
cdcd80f to
efe9924
Compare
ilovepi
force-pushed
the
users/ilovepi/new-arenas-12
branch
2 times, most recently
from
e135197 to
988d19a
Compare
ilovepi
force-pushed
the
users/ilovepi/new-arenas-11
branch
2 times, most recently
from
15a7d09 to
c02aa6c
Compare
ilovepi
force-pushed
the
users/ilovepi/new-arenas-12
branch
2 times, most recently
from
ae9905e to
f8e2614
Compare
ilovepi
force-pushed
the
users/ilovepi/new-arenas-11
branch
2 times, most recently
from
4c9b84d to
91e9881
Compare
ilovepi
force-pushed
the
users/ilovepi/new-arenas-12
branch
from
f8e2614 to
ad3d2b2
Compare
ilovepi
force-pushed
the
users/ilovepi/new-arenas-11
branch
from
2a88b20 to
479a4cc
Compare
ilovepi
force-pushed
the
users/ilovepi/new-arenas-12
branch
2 times, most recently
from
9f29f54 to
e303eef
Compare
ilovepi
force-pushed
the
users/ilovepi/new-arenas-11
branch
from
479a4cc to
73ba5f6
Compare
This was referenced Apr 3, 2026
evelez7
approved these changes
Apr 10, 2026
Member
evelez7
left a comment
evelez7
left a comment
There was a problem hiding this comment.
LGTM just some nits on the index capitalization. They will end up producing style warning lines for editors/LSPs.
ilovepi
force-pushed
the
users/ilovepi/new-arenas-11
branch
from
73ba5f6 to
d56067d
Compare
ilovepi
force-pushed
the
users/ilovepi/new-arenas-12
branch
from
e303eef to
0d56841
Compare
ilovepi
force-pushed
the
users/ilovepi/new-arenas-11
branch
from
d56067d to
897ff4d
Compare
ilovepi
force-pushed
the
users/ilovepi/new-arenas-12
branch
from
0d56841 to
0968ad1
Compare
ilovepi
force-pushed
the
users/ilovepi/new-arenas-11
branch
from
897ff4d to
f902188
Compare
ilovepi
force-pushed
the
users/ilovepi/new-arenas-12
branch
from
0968ad1 to
38b8962
Compare
ilovepi
force-pushed
the
users/ilovepi/new-arenas-11
branch
from
f902188 to
2089414
Compare
ilovepi
force-pushed
the
users/ilovepi/new-arenas-12
branch
from
38b8962 to
22fcc6a
Compare
ilovepi
force-pushed
the
users/ilovepi/new-arenas-11
branch
from
2089414 to
6095677
Compare
ilovepi
force-pushed
the
users/ilovepi/new-arenas-12
branch
from
22fcc6a to
036be76
Compare
Upcoming changes to the merge step will necessitate that we clear the transient arenas and merge new items into the persistent arena. However there are some challenges with that, as the existing types typically don't want to be copied. We introduce some new APIs to simplify that task and ensure we don't accidentally leak memory. On the performance front, we reclaim about 2% of the overhead, bringing the cumulative overhead from the series of patches down to about 7% over the baseline. | Metric | Baseline | Prev | This | Culm% | Seq% | | :--- | :--- | :--- | :--- | :--- | :--- | | Time | 920.5s | 1014.5s | 991.5s | +7.7% | -2.3% | | Memory | 86.0G | 39.9G | 40.0G | -53.4% | +0.3% | | Benchmark | Baseline | Prev | This | Culm% | Seq% | | :--- | :--- | :--- | :--- | :--- | :--- | | BM_BitcodeReader_Scale/10 | 67.9us | 73.0us | 72.2us | +6.3% | -1.1% | | BM_BitcodeReader_Scale/10000 | 70.5ms | 17.1ms | 22.5ms | -68.1% | +31.6% | | BM_BitcodeReader_Scale/4096 | 23.2ms | 6.5ms | 6.6ms | -71.6% | +1.1% | | BM_BitcodeReader_Scale/512 | 509.4us | 850.1us | 898.7us | +76.4% | +5.7% | | BM_BitcodeReader_Scale/64 | 114.8us | 140.6us | 133.7us | +16.4% | -5.0% | | BM_EmitInfoFunction | 1.6us | 1.8us | 1.9us | +16.8% | +3.4% | | BM_Index_Insertion/10 | 2.3us | 4.1us | 4.1us | +78.7% | -0.5% | | BM_Index_Insertion/10000 | 3.1ms | 5.4ms | 5.3ms | +70.5% | -0.4% | | BM_Index_Insertion/4096 | 1.3ms | 2.1ms | 2.1ms | +66.0% | +0.7% | | BM_Index_Insertion/512 | 153.6us | 252.9us | 251.8us | +64.0% | -0.4% | | BM_Index_Insertion/64 | 18.1us | 30.4us | 30.2us | +67.4% | -0.5% | | BM_JSONGenerator_Scale/10 | 36.8us | 38.1us | 37.1us | +0.6% | -2.8% | | BM_JSONGenerator_Scale/10000 | 89.6ms | 84.2ms | 81.4ms | -9.1% | -3.3% | | BM_JSONGenerator_Scale/4096 | 33.7ms | 32.1ms | 31.0ms | -8.1% | -3.6% | | BM_JSONGenerator_Scale/512 | 1.9ms | 2.0ms | 1.9ms | -0.1% | -3.1% | | BM_JSONGenerator_Scale/64 | 222.4us | 232.5us | 222.9us | +0.2% | -4.1% | | BM_Mapper_Scale/10 | 2.5ms | 2.5ms | 2.5ms | -1.0% | -0.4% | | BM_Mapper_Scale/10000 | 104.3ms | 102.1ms | 112.3ms | +7.7% | +10.0% | | BM_Mapper_Scale/4096 | 44.3ms | 46.5ms | 45.0ms | +1.4% | -3.4% | | BM_Mapper_Scale/512 | 7.6ms | 7.4ms | 7.7ms | +1.1% | +3.3% | | BM_Mapper_Scale/64 | 3.1ms | 3.0ms | 3.0ms | -1.5% | -0.2% | | BM_MergeInfos_Scale/10000 | 12.2ms | 931.2us | 575.6us | -95.3% | -38.2% | | BM_MergeInfos_Scale/2 | 1.9us | 1.8us | 1.8us | -2.7% | +1.9% | | BM_MergeInfos_Scale/4096 | 2.8ms | 201.3us | 205.3us | -92.6% | +1.9% | | BM_MergeInfos_Scale/512 | 68.9us | 19.9us | 20.5us | -70.2% | +3.4% | | BM_MergeInfos_Scale/64 | 10.3us | 4.1us | 3.8us | -62.6% | -7.1% | | BM_MergeInfos_Scale/8 | 2.8us | 1.9us | 1.9us | -30.5% | +4.2% | | BM_SerializeFunctionInfo | 25.5us | 26.2us | 25.8us | +0.9% | -1.5% |
ilovepi
force-pushed
the
users/ilovepi/new-arenas-12
branch
from
036be76 to
0a54089
Compare
ilovepi
added a commit
that referenced
this pull request
Apr 11, 2026
This is a set of squashed reverts of recen clang doc patches, since its breaking something on Darwin builders: https://lab.llvm.org/buildbot/#/builders/23/builds/19172 Revert "[clang-doc][nfc] Default initialize all StringRef members (#191641)" This reverts commit 155b9b3. Revert "[clang-doc] Initialize StringRef members in Info types (#191637)" This reverts commit 489dab3. Revert "[clang-doc] Initialize member variable (#191570)" This reverts commit 5d64a44. Revert "[clang-doc] Merge data into persistent memory (#190056)" This reverts commit 21e0034. Revert "[clang-doc] Support deep copy between arenas for merging (#190055)" This reverts commit c70dae8.
ilovepi
added a commit
that referenced
this pull request
Apr 13, 2026
This is a set of squashed reverts of recen clang doc patches, since its breaking something on Darwin builders: https://lab.llvm.org/buildbot/#/builders/23/builds/19172 Revert "[clang-doc][nfc] Default initialize all StringRef members (#191641)" This reverts commit 155b9b3. Revert "[clang-doc] Initialize StringRef members in Info types (#191637)" This reverts commit 489dab3. Revert "[clang-doc] Initialize member variable (#191570)" This reverts commit 5d64a44. Revert "[clang-doc] Merge data into persistent memory (#190056)" This reverts commit 21e0034. Revert "[clang-doc] Support deep copy between arenas for merging (#190055)" This reverts commit c70dae8. Revert "[clang-doc] Move Info types into arenas (#190054)" This reverts commit d3318f8.
ilovepi
added a commit
that referenced
this pull request
Apr 13, 2026
This is a set of squashed reverts of recent clang doc patches, since its breaking something on Darwin builders: https://lab.llvm.org/buildbot/#/builders/23/builds/19172 Revert "[clang-doc][nfc] Default initialize all StringRef members (#191641)" This reverts commit 155b9b3. Revert "[clang-doc] Initialize StringRef members in Info types (#191637)" This reverts commit 489dab3. Revert "[clang-doc] Initialize member variable (#191570)" This reverts commit 5d64a44. Revert "[clang-doc] Merge data into persistent memory (#190056)" This reverts commit 21e0034. Revert "[clang-doc] Support deep copy between arenas for merging (#190055)" This reverts commit c70dae8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upcoming changes to the merge step will necessitate that we clear the
transient arenas and merge new items into the persistent arena. However
there are some challenges with that, as the existing types typically
don't want to be copied. We introduce some new APIs to simplify that
task and ensure we don't accidentally leak memory.
On the performance front, we reclaim about 2% of the overhead, bringing
the cumulative overhead from the series of patches down to about 7% over
the baseline.