[AMDGPU] Use ASan callback functions instead of inline checks in SW Lower LDS pass#190332
Draft
[AMDGPU] Use ASan callback functions instead of inline checks in SW Lower LDS pass#190332
Conversation
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
🐧 Linux x64 Test Results
✅ The build succeeded and all tests passed. |
🪟 Windows x64 Test Results
✅ The build succeeded and all tests passed. |
skc7
force-pushed
the
users/skc7/amdgpu/asan_report_fix
branch
from
e96ec28 to
c717890
Compare
skc7
force-pushed
the
users/skc7/amdgpu/asan_report_fix
branch
from
c717890 to
ded8e89
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR uses _asan{load,store}* callbacks instead of using inline checks, matching the approach in AddressSanitizer.cpp when UseCalls is true.