[Clang][NFC] Mark 3106 as implemented.#192256
Merged
Merged
Conversation
Member
|
@llvm/pr-subscribers-clang Author: Corentin Jabot (cor3ntin) ChangesThis was a wording clarification, but we add a test nonetheless. Full diff: https://github.com/llvm/llvm-project/pull/192256.diff 2 Files Affected:
diff --git a/clang/test/CXX/drs/cwg31xx.cpp b/clang/test/CXX/drs/cwg31xx.cpp
new file mode 100644
index 0000000000000..8b0200a1375f9
--- /dev/null
+++ b/clang/test/CXX/drs/cwg31xx.cpp
@@ -0,0 +1,15 @@
+// RUN: %clang_cc1 -std=c++98 -fexceptions -fcxx-exceptions -pedantic-errors -verify-directives -verify=expected %s
+// RUN: %clang_cc1 -std=c++11 -fexceptions -fcxx-exceptions -pedantic-errors -verify-directives -verify=expected %s
+// RUN: %clang_cc1 -std=c++14 -fexceptions -fcxx-exceptions -pedantic-errors -verify-directives -verify=expected %s
+// RUN: %clang_cc1 -std=c++17 -fexceptions -fcxx-exceptions -pedantic-errors -verify-directives -verify=expected %s
+// RUN: %clang_cc1 -std=c++20 -fexceptions -fcxx-exceptions -pedantic-errors -verify-directives -verify=expected %s
+// RUN: %clang_cc1 -std=c++23 -fexceptions -fcxx-exceptions -pedantic-errors -verify-directives -verify=expected %s
+// RUN: %clang_cc1 -std=c++2c -fexceptions -fcxx-exceptions -pedantic-errors -verify-directives -verify=expected %s
+
+
+namespace cwg3106 { // cwg3106: yes
+
+constexpr const char* str = R"(\u{1234})";
+static_assert(str[0] == '\\');
+
+} // namespace cwg3106
diff --git a/clang/www/cxx_dr_status.html b/clang/www/cxx_dr_status.html
index cb0236b46e580..04ffa0080fce6 100755
--- a/clang/www/cxx_dr_status.html
+++ b/clang/www/cxx_dr_status.html
@@ -21563,7 +21563,7 @@ <h2 id="cxxdr">C++ defect report implementation status</h2>
<td>[<a href="https://wg21.link/lex.universal.char">lex.universal.char</a>]</td>
<td>DR</td>
<td>Redundant exclusion of (non-existent) UCNs in <I>r-char-sequence</I>s</td>
- <td class="unknown" align="center">Unknown</td>
+ <td class="full" align="center">Yes</td>
</tr>
<tr id="3107">
<td><a href="https://cplusplus.github.io/CWG/issues/3107.html">3107</a></td>
|
Endilll
approved these changes
Apr 15, 2026
This was a wording clarification, but we add a test nonetheless.
🐧 Linux x64 Test Results
✅ The build succeeded and all tests passed. |
🪟 Windows x64 Test Results
✅ The build succeeded and all tests passed. |
Endilll
requested changes
Apr 15, 2026
Contributor
Endilll
left a comment
Endilll
left a comment
There was a problem hiding this comment.
Sorry, it took me a bit to realize, but the test should be gated to C++11 and newer modes because of raw string literals.
Endilll
reviewed
Apr 15, 2026
Endilll
approved these changes
Apr 15, 2026
Contributor
Endilll
left a comment
Endilll
left a comment
There was a problem hiding this comment.
You forgot to re-run make_cxx_dr_status.
LGTM otherwise.
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/66/builds/29437 Here is the relevant piece of the build log for the reference |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a wording clarification, but we add a test nonetheless.