[Hexagon] Relax toolchain check to accept ld in driver test#192596
Merged
Conversation
llvmbot
added
clang
Member
|
@llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-driver Author: quic-k ChangesFixes failures in Full diff: https://github.com/llvm/llvm-project/pull/192596.diff 1 Files Affected:
diff --git a/clang/test/Driver/hexagon-toolchain-picolibc.c b/clang/test/Driver/hexagon-toolchain-picolibc.c
index eec0ec4f23b45..8571e55620b9c 100644
--- a/clang/test/Driver/hexagon-toolchain-picolibc.c
+++ b/clang/test/Driver/hexagon-toolchain-picolibc.c
@@ -67,7 +67,7 @@
// RUN: -ccc-install-dir %S/Inputs/hexagon_tree/Tools/bin -mcpu=hexagonv60 \
// RUN: -nolibc %s 2>&1 | FileCheck -check-prefix=CHECK-NOLIBC %s
// CHECK-NOLIBC: "-cc1"
-// CHECK-NOLIBC: hexagon-link
+// CHECK-NOLIBC: {{hexagon-link|ld}}
// CHECK-NOLIBC-SAME: "{{.*}}crt0-semihost.o"
// CHECK-NOLIBC-SAME: "-lc++"
// CHECK-NOLIBC-SAME: "-lm"
|
🐧 Linux x64 Test Results
✅ The build succeeded and all tests passed. |
🪟 Windows x64 Test Results
✅ The build succeeded and all tests passed. |
Update hexagon-toolchain-picolibc.c test to match either `hexagon-link` or `ld` when verifying driver output. This accounts for environments where the linker is invoked directly instead of via hexagon-link. Signed-off-by: Kushal Pal <kushpal@qti.qualcomm.com>
androm3da
approved these changes
Apr 17, 2026
alexfh
pushed a commit
to alexfh/llvm-project
that referenced
this pull request
Apr 18, 2026
) Fixes failures in https://lab.llvm.org/buildbot/#/builders/145/builds/13829 https://lab.llvm.org/buildbot/#/builders/124/builds/2152 Signed-off-by: Kushal Pal <kushpal@qti.qualcomm.com>
KHicketts
pushed a commit
to KHicketts/llvm-project
that referenced
this pull request
Apr 30, 2026
) Fixes failures in https://lab.llvm.org/buildbot/#/builders/145/builds/13829 https://lab.llvm.org/buildbot/#/builders/124/builds/2152 Signed-off-by: Kushal Pal <kushpal@qti.qualcomm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes failures in
https://lab.llvm.org/buildbot/#/builders/145/builds/13829
https://lab.llvm.org/buildbot/#/builders/124/builds/2152