Skip to content

Fix failure for clang/test/Frontend/rewrite-includes-bom.c for zOS#197501

Merged
abhina-sree merged 1 commit into
llvm:mainfrom
bahareh-farhadi:baharehfarhadi/fix_bom_case_lit
May 13, 2026
Merged

Fix failure for clang/test/Frontend/rewrite-includes-bom.c for zOS#197501
abhina-sree merged 1 commit into
llvm:mainfrom
bahareh-farhadi:baharehfarhadi/fix_bom_case_lit

Conversation

@bahareh-farhadi
Copy link
Copy Markdown
Contributor

This test is failing on zOS due to the lowercase HEX characters in the BOM. This PR changes the test to do a case-insensitive search.

@llvmorg-github-actions llvmorg-github-actions Bot added the clang Clang issues not falling into any other category label May 13, 2026
@llvmorg-github-actions
Copy link
Copy Markdown

@llvm/pr-subscribers-clang

Author: bahareh-farhadi

Changes

This test is failing on zOS due to the lowercase HEX characters in the BOM. This PR changes the test to do a case-insensitive search.


Full diff: https://github.com/llvm/llvm-project/pull/197501.diff

1 Files Affected:

  • (modified) clang/test/Frontend/rewrite-includes-bom.c (+2-2)
diff --git a/clang/test/Frontend/rewrite-includes-bom.c b/clang/test/Frontend/rewrite-includes-bom.c
index 0c60ee66c8e73..a0259da4f4678 100644
--- a/clang/test/Frontend/rewrite-includes-bom.c
+++ b/clang/test/Frontend/rewrite-includes-bom.c
@@ -1,6 +1,6 @@
-// RUN: cat %S/Inputs/rewrite-includes-bom.h | od -t x1 | grep -q 'ef[[:space:]]*bb[[:space:]]*bf'
+// RUN: cat %S/Inputs/rewrite-includes-bom.h | od -t x1 | grep -qi 'ef[[:space:]]*bb[[:space:]]*bf'
 // RUN: %clang_cc1 -E -frewrite-includes -I %S/Inputs %s -o %t.c
-// RUN: cat %t.c | od -t x1 | not grep -q 'ef[[:space:]]*bb[[:space:]]*bf'
+// RUN: cat %t.c | od -t x1 | not grep -qi 'ef[[:space:]]*bb[[:space:]]*bf'
 // RUN: %clang_cc1 -fsyntax-only -verify %t.c
 // expected-no-diagnostics
 // UNSUPPORTED: system-windows

Copy link
Copy Markdown
Member

@abhina-sree abhina-sree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abhina-sree abhina-sree merged commit f4d0481 into llvm:main May 13, 2026
12 checks passed
EuphoricThinking pushed a commit to EuphoricThinking/llvm-project that referenced this pull request May 14, 2026
…lvm#197501)

This test is failing on zOS due to the lowercase HEX characters in the BOM. This PR changes the test to do a case-insensitive search.
pedroMVicente pushed a commit to pedroMVicente/llvm-project that referenced this pull request May 19, 2026
…lvm#197501)

This test is failing on zOS due to the lowercase HEX characters in the BOM. This PR changes the test to do a case-insensitive search.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clang Clang issues not falling into any other category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants