[DAG] Adding MVT::widenIntegerElementType to widen both Scalar and Vectors of integer type.#207148
Merged
Conversation
Contributor
Author
|
cc @RKSimon |
RKSimon
requested changes
Jul 2, 2026
RKSimon
left a comment
RKSimon
left a comment
Contributor
There was a problem hiding this comment.
Find a few examples of uses - no need to be exhaustive, but you should have scalar vector and combined scalar/vector coverage.
HexagonISelLowering.cpp has a few examples
Contributor
Author
|
I have made few replacement in Hexagon target files and ran check-llvm test. I would appreciate if someone from Hexagon target maintainer could take a look. Changes seem minor to my eyes. Thank you. |
RKSimon
reviewed
Jul 6, 2026
RKSimon
reviewed
Jul 7, 2026
| nxv2i32.getSizeInBits()); | ||
| } | ||
|
|
||
| TEST(ScalableVectorMVTsTest, WideningIntegerMVTs) { |
Contributor
There was a problem hiding this comment.
None of these are scalable vector tests
Contributor
Author
There was a problem hiding this comment.
Could you kindly point me to the file where these tests should go ? or should I add new unittest file MVTTests.cpp with these tests?
RKSimon
approved these changes
Jul 8, 2026
RKSimon
left a comment
RKSimon
left a comment
Contributor
There was a problem hiding this comment.
LGTM - cheers (Codegen usage is a lot more useful than unit tests here)
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/228/builds/4056 Here is the relevant piece of the build log for the reference |
RKSimon
pushed a commit
that referenced
this pull request
Jul 8, 2026
Fixes build failure introduced by commit [736771b] (736771b) into llvm:main Ref : #207148 Failure : https://lab.llvm.org/buildbot/#/builders/228/builds/4056
llvm-sync Bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Jul 8, 2026
Fixes build failure introduced by commit [736771b] (llvm/llvm-project@736771b) into llvm:main Ref : llvm/llvm-project#207148 Failure : https://lab.llvm.org/buildbot/#/builders/228/builds/4056
llvm-upstreamsync Bot
pushed a commit
to qualcomm/cpullvm-toolchain
that referenced
this pull request
Jul 8, 2026
Fixes build failure introduced by commit [736771b] (llvm/llvm-project@736771b) into llvm:main Ref : llvm/llvm-project#207148 Failure : https://lab.llvm.org/buildbot/#/builders/228/builds/4056
llvm-upstream-sync Bot
pushed a commit
to sriyalamar/cpullvm-toolchain
that referenced
this pull request
Jul 8, 2026
Fixes build failure introduced by commit [736771b] (llvm/llvm-project@736771b) into llvm:main Ref : llvm/llvm-project#207148 Failure : https://lab.llvm.org/buildbot/#/builders/228/builds/4056
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding MVT::widenIntegerElementType to widen both Scalar and Vectors of integer type. e.g. i16 -> i32, v8i32->v8i64.
fixes #206730