Skip to content

[TBAA] Add bail-out to skip tbaa generation to getTBAAStructInfo. #84386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fhahn merged 1 commit into from
Mar 8, 2024
Merged

[TBAA] Add bail-out to skip tbaa generation to getTBAAStructInfo. #84386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions clang/lib/CodeGen/CodeGenTBAA.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,6 +343,9 @@ CodeGenTBAA::CollectFields(uint64_t BaseOffset,

llvm::MDNode *
CodeGenTBAA::getTBAAStructInfo(QualType QTy) {
if (CodeGenOpts.OptimizationLevel == 0 || CodeGenOpts.RelaxedAliasing)
return nullptr;

const Type *Ty = Context.getCanonicalType(QTy).getTypePtr();

if (llvm::MDNode *N = StructMetadataCache[Ty])
Expand Down
2 changes: 0 additions & 2 deletions clang/test/CodeGen/tbaa-struct-relaxed-aliasing-with-tsan.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,7 @@
// RUN: FileCheck %s
//
// Check that we do not create tbaa for instructions generated for copies.
// FIXME: !tbaa.struct is generated with null node as tag.

// CHECK: !tbaa.struct
// CHECK-NOT: !tbaa

struct A {
Expand Down