Skip to content

[DwarfGenerator] Calculate relative offset according to Dwarf Version #84847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hawkinsw merged 1 commit into from
Mar 20, 2024
Merged

[DwarfGenerator] Calculate relative offset according to Dwarf Version #84847

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions llvm/unittests/DebugInfo/DWARF/DwarfGenerator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -568,12 +568,20 @@ StringRef dwarfgen::Generator::generate() {
for (auto &CU : CompileUnits) {
// Set the absolute .debug_info offset for this compile unit.
CU->setOffset(SecOffset);
// The DIEs contain compile unit relative offsets.
unsigned CUOffset = 11;
// The DIEs contain compile unit relative offsets and the offset depends
// on the Dwarf version.
unsigned CUOffset = 4 + // Length
2 + // Version
4 + // Abbreviation offset
1; // Address size
if (Asm->getDwarfVersion() >= 5)
CUOffset += 1; // DW_UT_compile tag.

CUOffset = CU->getUnitDIE().computeSizeAndOffsets(CUOffset);
// Update our absolute .debug_info offset.
SecOffset += CUOffset;
CU->setLength(CUOffset - 4);
unsigned CUOffsetUnitLength = 4;
CU->setLength(CUOffset - CUOffsetUnitLength);
}
Abbreviations.Emit(Asm.get(), TLOF->getDwarfAbbrevSection());

Expand Down