Updates to 'tosa.reshape' verifier

[rafaelubalmw]

This addition catches common cases of malformed tosa.reshape ops. This prevents the --tosa-to-tensor pass from asserting when fed invalid operations, as these will be caught ahead of time by the verifier.

Closes #87396

[github-actions]

⚠️ C/C++ code formatter, clang-format found issues in your code. ⚠️

You can test this locally with the following command:

git-clang-format --diff 133156c1380ef592ad0fb2dd44473f583dbee1b7 afa07be2613d29ebfe86cef2a2f276ba51ee3789 -- mlir/lib/Dialect/Tosa/IR/TosaOps.cpp

View the diff from clang-format here.

diff --git a/mlir/lib/Dialect/Tosa/IR/TosaOps.cpp b/mlir/lib/Dialect/Tosa/IR/TosaOps.cpp
index e06ac9a27a..74e8096292 100644
--- a/mlir/lib/Dialect/Tosa/IR/TosaOps.cpp
+++ b/mlir/lib/Dialect/Tosa/IR/TosaOps.cpp
@@ -962,7 +962,7 @@ mlir::LogicalResult tosa::ReshapeOp::verify() {
     return emitOpError() << "tensor has a dimension with size zero. Each "
                             "dimension of a tensor must have size >= 1";
 
-  if ((int64_t) getNewShape().size() != outputType.getRank())
+  if ((int64_t)getNewShape().size() != outputType.getRank())
     return emitOpError() << "new shape does not match result rank";
 
   for (auto [newShapeDim, outputShapeDim] :

[sabauma]

These checks seem reasonable to me.

[bjacob]

Thanks!