[dsymutil] Support generating dSYMs for firmware environments #87432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support generating dSYM companion files for (non-Darwin) firmware environments by considering the binary component of the triple in addition to the OS component. rdar://125629792
jasonmolenda
approved these changes
Apr 3, 2024
Collaborator
jasonmolenda
left a comment
jasonmolenda
left a comment
There was a problem hiding this comment.
This looks good to me, nice job coming up with a simple test case binary for this environment. Yes, I think the simple rubric of "if this is a Mach-O binary, creating a dSYM is the correct behavior" instead of checking for whether the binary is iOS/macOS/etc is good.
JDevlieghere
added a commit
to swiftlang/llvm-project
that referenced
this pull request
Apr 4, 2024
[dsymutil] Support generating dSYMs for firmware environments (llvm#87432)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support generating dSYM companion files for (non-Darwin) firmware environments by considering the binary component of the triple in addition to the OS component.
rdar://125629792