[Vectorizer] Convert index-select to comprehensive arg(min|max) tests. #299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generalize and extend the tests in index-select.cpp to cover argmin/argmax with both finding the first and last indices. The test cases cover a range of predicates (<, <=, >, >=) with a range of initial values, trip counts and types. This adds extensive test coverage for llvm/llvm-project#141431 and follow-ups.
fhahn
force-pushed
the
arg-min-max-tests
branch
from
aebb36d to
78c6721
Compare
Meinersbur
reviewed
Dec 1, 2025
Member
Meinersbur
left a comment
Meinersbur
left a comment
There was a problem hiding this comment.
No checking for negative 0, infinity, NaN?
| for (unsigned long i = 0; i < OuterTC; i++) { \ | ||
| _Pragma("clang loop vectorize(disable) interleave_count(1)") \ | ||
| for (unsigned long j = 0; j < InnerTC; j++) { \ | ||
| _Pragma("clang loop vectorize(disable) interleave_count(1)") for ( \ |
Member
There was a problem hiding this comment.
[nit] whitespace change noise?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generalize and extend the tests in index-select.cpp to cover argmin/argmax with both finding the first and last indices.
The test cases cover a range of predicates (<, <=, >, >=) with a range of initial values, trip counts and types.
This adds extensive test coverage for
llvm/llvm-project#141431 and follow-ups.