[GHA] Use pip and venv to install buildbot for lit tests #302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Installing a specific version of buildbot is more robust to future changes vs using whatever is packaged for Debian.
asb
requested review from
DavidSpickett,
andreil99,
gkistanova and
vvereschaka
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installing a specific version of buildbot is more robust to future changes vs using whatever is packaged for Debian.
See here for an example of this working https://github.com/asb/llvm-zorg/actions/runs/11765732176/job/32772399920
I want to move over to this as a precursor to adding
buildbot checkconfigto this flow, taking advantage of the local testing mode added in #289.As a sidenote, the
run:line can be changed to justlit -v --xfail jenkins/test_build.py test(as in the setup stage I'd added a symlink to allow this, but forgot to change the run line). I've left that change out of this PR to avoid changing two things at once, and as it's trivial I'd intend to just directly commit.