[AMDGPU][Offload] Enable flang-rt build on amdhsa #666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent changes in CMake require to explicitly build the flang-rt for the offload target.
Meinersbur
approved these changes
Nov 27, 2025
Member
Meinersbur
left a comment
Meinersbur
left a comment
There was a problem hiding this comment.
Background: llvm/llvm-project#169638 makes the Fortran modules files specific for each target. That means to run the offload Fortran tests, it needs the amdgpu-amd-amdhsa module files which are generated by flang-rt.
Will need to wait for llvm/llvm-project#169638 to land. Without it it will try to compile the entire runtime for amdgpu-amd-amdhsa which according to llvm/llvm-project#131826 is experimental and when I tried failed because of missing C++ headers.
Contributor
Author
|
Thank you for the links to the related LLVM PRs. Feel free to land this when you landed the other PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent changes in CMake require to explicitly build the flang-rt for the offload target.