[VK] Gate debug utils messenger on runtime config instead of NDEBUG#1269
Merged
MarijnS95 merged 1 commit intoJun 5, 2026
Merged
Conversation
The extension registration was already converted to runtime config flags in llvm#382, but the call site for `registerDebugUtilCallback` was left gated on `#ifndef NDEBUG`. In `NDEBUG` builds this made the function unused and triggered `-Wunused-function`, and at the same time decoupled the callback from whether `VK_EXT_debug_utils` was actually loaded. Tie the callback to the extension actually being enabled, and pull the extension in whenever either `EnableDebugLayer` or `EnableValidationLayer` is set so validation messages route through the callback (matching the DX backend's coupling in `lib/API/DX/Device.cpp`). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Collaborator
Author
|
I.e. I've been seeing this on |
EmilioLaiso
approved these changes
Jun 4, 2026
bogner
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
registerDebugUtilCallbackwas only invoked inside#ifndef NDEBUG, leaving the function unused (and triggering-Wunused-function) inNDEBUGbuilds. The extension registration itself had already been converted to runtime config flags in #382; the call site was missed.Tie the callback to whether
VK_EXT_debug_utilswas actually enabled, and pull the extension in whenever eitherEnableDebugLayerorEnableValidationLayeris set — so validation messages route through the callback. This matches how the DX backend couples the two flags inlib/API/DX/Device.cpp.🤖 Generated with Claude Code