[SPIRV] Add a means of turning off/on tests for specific spirv drivers#678
[SPIRV] Add a means of turning off/on tests for specific spirv drivers#678
Conversation
| " (" + std::string(DriverProps.driverName, DriverNameSz) + ")"; | ||
| #endif | ||
| DriverName = std::string(DriverProps.driverName, DriverNameSz); | ||
| Description += " (" + DriverName + ")"; |
There was a problem hiding this comment.
Would it be better to leave description alone and just print the driver name as well in api-query?
There was a problem hiding this comment.
So we might not need to do this string append on linux vulkan but we do need to do it on apple vulkan right now the device description is the same across vulkan instances
vulkaninfo --summary | grep deviceName
deviceName = Apple M3 Max
deviceName = Apple M3 Max
vulkaninfo --summary | grep driverName
driverName = MoltenVK
driverName = KosmicKrisp
There was a problem hiding this comment.
alternatively we could have adapter-regex do matching on description and device name? I dunno if that is better though?
There was a problem hiding this comment.
Oh, I see. You want a combined string for the filtering mechanism. Okay, that's probably fine.
|
|
||
| # Unimplemented: https://github.com/llvm/offload-test-suite/issues/664 | ||
| # XFAIL: DirectX || Metal | ||
| # XFAIL: DirectX || Metal || Vulkan && Darwin |
There was a problem hiding this comment.
Is this the right issue? It's specifically about DirectX and Metal support for samplers being unimplemented.
There was a problem hiding this comment.
From what I can tell this is a Metal issue and so MoltenVK runs into the same problem. I didn't look to deeply into why KosmicKrisp is also failing.
| # GetDimensions on Vulkan (DXC) returns [ 16, 16 ] instead of [ 8, 5 ] | ||
| # except on AMD https://github.com/llvm/offload-test-suite/issues/523 | ||
| # XFAIL: DXC && Vulkan && !AMD | ||
| # XFAIL: DXC && Vulkan && !Darwin && !AMD |
There was a problem hiding this comment.
Does the comment need to be updated here?
There was a problem hiding this comment.
Yeah I'm thinking it would be easier to update this to
XFAIL: DXC && Vulkan && (Nvidia || Intel)
Because its passing on Mac across both KosmicKrisp and MoltenVK
There was a problem hiding this comment.
I didn't because I actually don't have an integrated intel gpu to test on and the intel CI is down right now so I don't know how to confirm this.
| " (" + std::string(DriverProps.driverName, DriverNameSz) + ")"; | ||
| #endif | ||
| DriverName = std::string(DriverProps.driverName, DriverNameSz); | ||
| Description += " (" + DriverName + ")"; |
There was a problem hiding this comment.
Oh, I see. You want a combined string for the filtering mechanism. Okay, that's probably fine.
| config.available_features.add(API) | ||
| config.available_features.add(compiler) | ||
| config.available_features.add(config.offloadtest_os) | ||
| if device["Driver"]: |
There was a problem hiding this comment.
This seems to only make sense for mesa drivers. On linux we get names
driverName = NVK
driverName = llvmpipe
driverName = venus
But on windows it is:
driverName = Intel Corporation
driverName = NVIDIA
driverName = AMD proprietary driver
I think for now we should limit this to Mac and maybe expand it to Linux later. It seems mostly useless on Windows.
In the testing of KosmicKrisp Many tests for MoltenVK were XFAIL resulting in unexpected passes. This change makes those tests XFAIL for just MoltenVK.
farzonl
force-pushed
the
update_api-query
branch
from
92b6d91 to
ddc67e3
Compare
4 participants
In the testing of KosmicKrisp Many tests for MoltenVK were XFAIL resulting in unexpected passes. This change makes those tests XFAIL for just MoltenVK.
Results