Removed XFAIL for Clang config for QuadReadAcrossX#994
Draft
kcloudy0717 wants to merge 3 commits intollvm:mainfrom
Draft
Removed XFAIL for Clang config for QuadReadAcrossX#994kcloudy0717 wants to merge 3 commits intollvm:mainfrom
kcloudy0717 wants to merge 3 commits intollvm:mainfrom
Conversation
We can remove the XFAIL directives for Clang config for QuadReadAcrossX tests now that QuadReadAcrossX intrinsic has landed in LLVM: llvm/llvm-project#184360
kcloudy0717
force-pushed
the
kcloudy0717/xfail/QuadReadAcrossX
branch
from
1e1b6c6 to
00a040e
Compare
inbelic
reviewed
Mar 19, 2026
Contributor
inbelic
left a comment
inbelic
left a comment
There was a problem hiding this comment.
LGTM once we change !Clang -> DXC
Thanks for putting this up right away :)
test/WaveOps/QuadReadAcrossX.32.test
Outdated
|
|
||
| # Bug: https://github.com/llvm/offload-test-suite/issues/986 | ||
| # XFAIL: Intel && Vulkan | ||
| # XFAIL: Intel && Vulkan && !Clang |
Contributor
There was a problem hiding this comment.
Suggested change
| # XFAIL: Intel && Vulkan && !Clang | |
| # XFAIL: Intel && Vulkan && DXC |
Same with below
Contributor
Author
There was a problem hiding this comment.
I've updated all of the !Clang condition to DXC.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can remove the XFAIL directives for Clang config for QuadReadAcrossX tests now that QuadReadAcrossX intrinsic has landed in LLVM: llvm/llvm-project#184360