Skip to content

[torch] Implement stronger verifiers for non-value semantic ops #2519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2023
Merged

[torch] Implement stronger verifiers for non-value semantic ops #2519

merged 1 commit into from
Oct 21, 2023

Conversation

@gptsarthak
Copy link
Contributor

@gptsarthak gptsarthak commented Oct 18, 2023

Attempt to solve #2490

Changes for Non Value Semantic Ops having the IsTrailingUnderscoreInplaceVariant trait :

  • AnyTorchTensorType -> Torch_NonValueTensorType
  • AnyTorchOptionalTensorType -> AnyTorchOptionalNonValueTensorType
  • AnyTorchListOfOptionalTensorType -> AnyTorchListOfOptionalNonValueTensorType
  • AnyTorchListOfTensorType -> AnyTorchListOfNonValueTensorType

Created three new tensor types for optional and list non value tensors.

@gptsarthak gptsarthak mentioned this pull request Oct 21, 2023
Closed
stellaraccident
stellaraccident approved these changes Oct 21, 2023
View reviewed changes
Copy link
Collaborator

@stellaraccident stellaraccident left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@stellaraccident stellaraccident merged commit 7633619 into llvm:main Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stellaraccident stellaraccident stellaraccident approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gptsarthak @stellaraccident