Rework AtenEmptyStridedOp checks #2537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan-garvey
force-pushed
the
reworkEmptyStrided
branch
from
e7ff196 to
ff023c2
Compare
qedawkins
requested changes
Oct 31, 2023
Collaborator
qedawkins
left a comment
qedawkins
left a comment
There was a problem hiding this comment.
A large portion of the changes here look like something is wonky with the linter and it makes it a harder to review. Any idea what's going on here?
dan-garvey
force-pushed
the
reworkEmptyStrided
branch
2 times, most recently
from
f11eb1b to
74df033
Compare
qedawkins
reviewed
Oct 31, 2023
dan-garvey
force-pushed
the
reworkEmptyStrided
branch
from
74df033 to
1cd0048
Compare
qedawkins
approved these changes
Oct 31, 2023
dan-garvey
force-pushed
the
reworkEmptyStrided
branch
from
1cd0048 to
e7c0fd3
Compare
Deduplicate code and add dynamic support
dan-garvey
force-pushed
the
reworkEmptyStrided
branch
from
e7c0fd3 to
2d92c0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now using Value instead of Ints. Trades compile failure for a runtime assert