-
Notifications
You must be signed in to change notification settings - Fork 621
[Torch Dialect] Decompose AtenTriuOp #2561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qingyunqu
requested changes
Nov 9, 2023
qingyunqu
requested changes
Nov 13, 2023
9705520 to
0fc2345
Compare
ed1cac4 to
5618886
Compare
qingyunqu
approved these changes
Nov 14, 2023
Collaborator
qingyunqu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Collaborator
|
@ramiro050 Could you please review this PR? |
5618886 to
3721e95
Compare
ramiro050
requested changes
Nov 15, 2023
3721e95 to
c5ffd81
Compare
c5ffd81 to
7bd6e9c
Compare
ramiro050
approved these changes
Nov 28, 2023
Collaborator
ramiro050
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one request
qingyunqu
reviewed
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
decompose like: