-
Notifications
You must be signed in to change notification settings - Fork 631
[Torch] add aten.bilinear op decomposing #3931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi @vivekkhandelwal1. I don't have permission to request review yet. Do you mind taking a look at this change? Thanks! |
|
Hi @vivekkhandelwal1, a gentle reminder to review this pull request when you get a chance. Thank you! |
@dixinzhou Is this PR still active and needs a review? |
Hi @vivekkhandelwal1, thanks for the reply. Yes, this PR still needs to be reviewed and upstreamed. |
|
Hi @vivekkhandelwal1. I have updated the pull request per your review feedback. Do you mind taking another look at this change? Thanks! |
|
Hi @vivekkhandelwal1. I have another round of updates according to your review feedback. Can you take a look? Thanks! |
|
Hi @vivekkhandelwal1. Would you mind taking a look to see if this change is ready to be merged? Thanks! |
This PR adds support for
aten.bilinearop. Theaten.bilinearop is decomposed toaten._trilinearandaten.addaccording to https://github.com/pytorch/pytorch/blob/main/aten/src/ATen/native/Linear.cpp#L712.Additionally, this PR fixes a bug in
aten._trilinearop decomposition about tensor shape mismatch.