Skip to content

Conversation

@dixinzhou
Copy link
Contributor

This PR adds support for aten.bilinear op. The aten.bilinear op is decomposed to aten._trilinear and aten.add according to https://github.com/pytorch/pytorch/blob/main/aten/src/ATen/native/Linear.cpp#L712.

Additionally, this PR fixes a bug in aten._trilinear op decomposition about tensor shape mismatch.

@dixinzhou
Copy link
Contributor Author

Hi @vivekkhandelwal1. I don't have permission to request review yet. Do you mind taking a look at this change? Thanks!

@dixinzhou
Copy link
Contributor Author

Hi @vivekkhandelwal1, a gentle reminder to review this pull request when you get a chance. Thank you!

@vivekkhandelwal1
Copy link
Collaborator

Hi @vivekkhandelwal1, a gentle reminder to review this pull request when you get a chance. Thank you!

@dixinzhou Is this PR still active and needs a review?

@dixinzhou
Copy link
Contributor Author

Hi @vivekkhandelwal1, a gentle reminder to review this pull request when you get a chance. Thank you!

@dixinzhou Is this PR still active and needs a review?

Hi @vivekkhandelwal1, thanks for the reply. Yes, this PR still needs to be reviewed and upstreamed.

@dixinzhou
Copy link
Contributor Author

Hi @vivekkhandelwal1. I have updated the pull request per your review feedback. Do you mind taking another look at this change? Thanks!

@dixinzhou
Copy link
Contributor Author

Hi @vivekkhandelwal1. I have another round of updates according to your review feedback. Can you take a look? Thanks!

@dixinzhou
Copy link
Contributor Author

dixinzhou commented Sep 12, 2025

Hi @vivekkhandelwal1. Would you mind taking a look to see if this change is ready to be merged? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants