Skip to content

[NFC] Split BackendTypeConversion #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 22, 2022
Merged

[NFC] Split BackendTypeConversion #686

merged 1 commit into from
Mar 22, 2022

Conversation

@asaadaldien
Copy link
Member

@asaadaldien asaadaldien commented Mar 22, 2022

  • Split BackendTypeConversion -> (BackendTypeConversion, BackendTypeConversionPasses) so BackendTypeConversion.cpp only provides definitions for BackendTypeConversion.h declarations and
    BackendTypeConversionPasses.cpp provides definitions for create**Pass() declarations in orchConversion/Transforms/Passes.h

  • This removes cyclic decency BackendTypeConversion -> TorchConversion/Transforms/Passes -> torch-mlir/Conversion/** --> BackendTypeConversion.

@asaadaldien asaadaldien marked this pull request as ready for review March 22, 2022 20:17
@asaadaldien asaadaldien mentioned this pull request Mar 22, 2022
Closed
@silvasean silvasean merged commit f9d3459 into llvm:main Mar 22, 2022
@silvasean
Copy link
Contributor

silvasean commented Mar 22, 2022

Thanks!

qedawkins pushed a commit to nod-ai/torch-mlir that referenced this pull request Oct 3, 2022
@negiyas
Add builders for ONNX operation definitions to allow to build them by…
acd9d09 
… Table-driven Declarative Rewrite Rules (llvm#686)

* Add builder for onnx.split and onnx.identity

* Update src/Dialect/ONNX/ONNXOps.td.inc by utils/gen_onnx_mlir.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@silvasean silvasean Awaiting requested review from silvasean

@cathyzhyi cathyzhyi Awaiting requested review from cathyzhyi

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@asaadaldien @silvasean