Scope MiniEngine shader features

[llvm-beanz]

Scope out missing shader features to support MiniEngine.

There are ~220 shader files in the project and each should be evaluated for feature use

The list of all shaders are included in a comment below

[RSzipper]

Hi @llvm-beanz ,

I’m interested in working on #194 – Scope MiniEngine shader features and had a few questions before I start:

Do you want a list of existing shader features or ideas for new ones?
Should I focus on specific shader types (like vertex, pixel, compute) or cover all of them?
Are you expecting a document or actual code changes?
Just want to make sure I’m on the right track. Thanks!

[V-FEXrt]

@RSzipper Thanks for volunteering to take this on however this task is a rather large one that we are using to scope future work items. Because of this we are going to directly work on this issue internally.

You can try to keep an eye out for good first issue tasks here https://github.com/llvm/llvm-project/issues?q=is%3Aissue%20state%3Aopen%20label%3A%22good%20first%20issue%22 though they are often claimed quite quickly

[V-FEXrt]

Edit: The list of files here is far to long/cluttery and not useful info. The shaders are listed at https://github.com/microsoft/DirectX-Graphics-Samples/tree/master/MiniEngine/Core/Shaders and https://github.com/microsoft/DirectX-Graphics-Samples/tree/master/MiniEngine/Model/Shaders

[V-FEXrt]

Here are the unique error messages generated from compiling the shaders. This is likely not all of them as errors can hide other errors but its a good start.

Compute Shader Unique Errors

error: binding type 's' only applies to sampler state
error: binding type 't' only applies to SRV resources
error: binding type 'u' only applies to UAV resources
error: call to 'clamp' is ambiguous
error: call to 'dot' is ambiguous
error: call to 'lerp' is ambiguous
error: call to 'max' is ambiguous
error: call to 'min' is ambiguous
error: call to 'pow' is ambiguous
error: expected ';' at end of declaration list
error: illegal scalar extension cast on argument 'Quad[0]' to inout paramemter
error: illegal scalar extension cast on argument 'Quad[1]' to inout paramemter
error: illegal scalar extension cast on argument 'Quad[2]' to inout paramemter
error: illegal scalar extension cast on argument 'Quad[3]' to inout paramemter
error: no matching function for call to 'smoothstep'
error: no member named 'InterlockedAdd' in 'hlsl::RWByteAddressBuffer'
error: no member named 'Load' in 'hlsl::ByteAddressBuffer'
error: no member named 'Load' in 'hlsl::RWByteAddressBuffer'
error: no member named 'Load2' in 'hlsl::RWByteAddressBuffer'
error: no member named 'Store' in 'hlsl::RWByteAddressBuffer'
error: no member named 'Store2' in 'hlsl::RWByteAddressBuffer'
error: no member named 'Store3' in 'hlsl::RWByteAddressBuffer'
error: no member named 'Store4' in 'hlsl::RWByteAddressBuffer'
error: no template named 'Buffer'; did you mean 'RWBuffer'?
error: no template named 'RWTexture2D'
error: no template named 'RWTexture2DArray'
error: no template named 'Texture2D'
error: no template named 'Texture2DArray'
error: resource has implicit register binding [-Whlsl-implicit-binding]
error: too many initializers in list for type 'const float3' (aka 'const vector<float, 3>') (expected 3 but found 9)
error: unknown HLSL semantic 'SV_POSITION'
error: unknown HLSL semantic 'TEXCOORD0'
error: unknown HLSL semantic 'TEXCOORD3'
error: unknown type name 'SamplerState'
error: unknown type name 'float3x3'; did you mean 'float3'?
error: unknown type name 'float3x4'
error: unknown type name 'float4x4'; did you mean 'float4'?
error: unknown type name 'matrix'
error: unknown type name 'nointerpolation'
error: use of undeclared identifier 'DeviceMemoryBarrierWithGroupSync'; did you mean 'GroupMemoryBarrierWithGroupSync'?
error: use of undeclared identifier 'InterlockedAdd'
error: use of undeclared identifier 'InterlockedMax'
error: use of undeclared identifier 'InterlockedMin'
error: use of undeclared identifier 'InterlockedOr'
error: use of undeclared identifier 'f16tof32'
error: use of undeclared identifier 'f32tof16'
error: use of undeclared identifier 'float3x4'
error: use of undeclared identifier 'float4x4'
error: use of undeclared identifier 'ldexp'
error: use of undeclared identifier 'mul'

Pixel & Vertex Shader Unique Errors

error: binding type 's' only applies to sampler state
error: binding type 't' only applies to SRV resources
error: call to 'Fresnel_Shlick' is ambiguous
error: call to 'clamp' is ambiguous
error: call to 'dot' is ambiguous
error: call to 'lerp' is ambiguous
error: call to 'max' is ambiguous
error: call to 'min' is ambiguous
error: call to 'pow' is ambiguous
error: duplicate member 'float3'
error: expected ';' at end of declaration list
error: no member named 'Color' in 'ParticleVertexOutput'
error: no member named 'Load' in 'hlsl::ByteAddressBuffer'
error: no member named 'TexID' in 'ParticleVertexOutput'
error: no member named 'bitangent' in 'VSOutput'
error: no member named 'normal' in 'VSOutput'
error: no member named 'position' in 'VSOutput'
error: no member named 'shadowCoord' in 'VSOutput'
error: no member named 'tangent' in 'VSOutput'
error: no member named 'uv' in 'VSOutput'
error: no member named 'viewDir' in 'VSOutput'
error: no member named 'worldPos' in 'VSOutput'
error: no template named 'Texture2D'
error: no template named 'Texture2DArray'
error: no template named 'Texture2DMS'
error: no template named 'TextureCube'
error: semantic annotations must be present for all parameters of an entry function or patch constant function
error: too many initializers in list for type 'const float3' (aka 'const vector<float, 3>') (expected 3 but found 9)
error: unknown HLSL semantic 'BITANGENT'
error: unknown HLSL semantic 'BLENDINDICES'
error: unknown HLSL semantic 'BLENDWEIGHT'
error: unknown HLSL semantic 'Bitangent'
error: unknown HLSL semantic 'COLOR'
error: unknown HLSL semantic 'NORMAL'
error: unknown HLSL semantic 'Normal'
error: unknown HLSL semantic 'POSITION'
error: unknown HLSL semantic 'SV_Depth'
error: unknown HLSL semantic 'SV_InstanceID'
error: unknown HLSL semantic 'SV_POSITION'
error: unknown HLSL semantic 'SV_Position'
error: unknown HLSL semantic 'SV_TARGET'
error: unknown HLSL semantic 'SV_Target'
error: unknown HLSL semantic 'SV_Target0'
error: unknown HLSL semantic 'SV_Target1'
error: unknown HLSL semantic 'SV_VertexID'
error: unknown HLSL semantic 'TANGENT'
error: unknown HLSL semantic 'TEXCOORD'
error: unknown HLSL semantic 'TEXCOORD0'
error: unknown HLSL semantic 'TEXCOORD1'
error: unknown HLSL semantic 'TEXCOORD2'
error: unknown HLSL semantic 'TEXCOORD3'
error: unknown HLSL semantic 'Tangent'
error: unknown HLSL semantic 'TexCoord0'
error: unknown HLSL semantic 'TexCoord1'
error: unknown HLSL semantic 'TexCoord2'
error: unknown HLSL semantic 'WorldPos'
error: unknown type name 'SamplerComparisonState'
error: unknown type name 'SamplerState'
error: unknown type name 'Texture2D'
error: unknown type name 'float3x3'; did you mean 'float3'?
error: unknown type name 'float4x3'
error: unknown type name 'float4x4'; did you mean 'float4'?
error: unknown type name 'nointerpolation'
error: unknown type name 'sample'
error: use of undeclared identifier 'ddx'
error: use of undeclared identifier 'ddy'
error: use of undeclared identifier 'discard'
error: use of undeclared identifier 'f16tof32'
error: use of undeclared identifier 'f32tof16'
error: use of undeclared identifier 'float3x3'
error: use of undeclared identifier 'ldexp'
error: use of undeclared identifier 'mul'

[V-FEXrt]

Okay! I believe the initial scoping of missing features is done! Please see the summary below

Workstreams

Intrinsics

#237
#264

Resources

#265

Language

#266

Root Signatures

#267

Testing

#237
#261

Semantics

#255

Tooling

#268

Other

#269

[V-FEXrt]

I think for now we can close this issue out. More scoping work will likely be needed once we start getting into DXIL/SPIRV generation but that will have to be revisited later. In the meantime, above and #234 are tracking the identified work.

Previous open questions:

• Shader flag work: Issue filed
• Container work: Issue filed
• DXC API/Reflection: I wasn't able to find any uses in MiniEngine. It doesn't import dxcapi.h and all mentions of reflection are the visual kind
• Does ModelViewer exercise every MiniEngine shader: Mostly no. Nearly all the shaders should be hooked up to various effects, but they complete. To test them all the tweaks menu needs to be used to toggle various options/code paths