Skip to content

Conversation

@dinmukhamedm
Copy link
Member

@dinmukhamedm dinmukhamedm commented Nov 27, 2025

Note

Removes synchronous/asynchronous Agent resources and related agent types, updates clients/exports accordingly, and streamlines types to use BaseModel/Field.

  • SDK Clients:
    • Remove Agent/AsyncAgent resources, their properties, and exports from synchronous/sync_client.py, asynchronous/async_client.py, and resources __init__ modules.
    • Retain Evals, Evaluators, BrowserEvents, Tags, and Datasets resources and accessors.
  • Types (sdk/types.py):
    • Delete agent-related models: RunAgentRequest, ActionResult, AgentOutput, RunAgentResponseChunk and chunk content types.
    • Refactor to from pydantic import BaseModel, Field; simplify imports/type hints.
    • Preserve evaluation models (Datapoint, Dataset, PartialEvaluationDatapoint, EvaluationResultDatapoint, etc.), LaminarSpanContext, and evaluator types; keep SessionRecordingOptions/MaskInputOptions.
  • Package Exports (__init__.py):
    • Remove agent-related symbols from __all__; continue exporting HumanEvaluator, clients, tracing utilities, and evaluation helpers.

Written by Cursor Bugbot for commit 0073791. This will update automatically on new commits. Configure here.


Important

Remove agent SDK resources and related types from asynchronous and synchronous clients, including AsyncAgent, Agent, and associated types.

  • Removal of Agent SDK Resources:
    • Deleted AsyncAgent class from async_client.py and agent.py.
    • Deleted Agent class from sync_client.py and agent.py.
    • Removed agent property from AsyncLaminarClient and LaminarClient.
  • Types Cleanup:
    • Removed AgentOutput, RunAgentRequest, RunAgentResponseChunk, FinalOutputChunkContent, StepChunkContent, and TimeoutChunkContent from types.py.
  • Imports and Exports:
    • Removed AsyncAgent and Agent from __init__.py files in resources directories.
    • Updated __all__ to exclude removed classes in __init__.py files.

This description was created by Ellipsis for 0073791. You can customize this summary. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 0073791 in 1 minute and 2 seconds. Click for details.
  • Reviewed 1089 lines of code in 8 files
  • Skipped 0 files when reviewing.
  • Skipped posting 6 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. src/lmnr/__init__.py:4
  • Draft comment:
    Removed agent-related types (AgentOutput, FinalOutputChunkContent, RunAgentResponseChunk, StepChunkContent). Ensure this breaking change is documented for users.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the PR author to ensure that a breaking change is documented for users. This falls under the rule of not asking the author to ensure behavior is intended or to update documentation, which is not allowed.
2. src/lmnr/sdk/client/asynchronous/async_client.py:90
  • Draft comment:
    Removed AsyncAgent initialization and property. Confirm that all consumers of AsyncLaminarClient are updated to reflect this removal.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the PR author to confirm that all consumers of AsyncLaminarClient are updated, which violates the rule against asking the author to confirm or ensure things. It doesn't provide a specific suggestion or point out a specific issue with the code.
3. src/lmnr/sdk/client/asynchronous/resources/__init__.py:1
  • Draft comment:
    Removed AsyncAgent from resource exports. Verify that downstream code no longer depends on it.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the PR author to verify that downstream code no longer depends on the removed export. This falls under the rule of not asking the author to ensure behavior or compatibility, which is not allowed.
4. src/lmnr/sdk/client/synchronous/resources/__init__.py:1
  • Draft comment:
    Agent resource export has been removed from the synchronous resources. Ensure that this removal is reflected in client usage and documentation.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the PR author to ensure that the removal of agent resource export is reflected in client usage and documentation. This falls under the category of asking the author to ensure something is done, which is against the rules.
5. src/lmnr/sdk/client/synchronous/sync_client.py:90
  • Draft comment:
    Removed Agent initialization and property from LaminarClient. Clients using the 'agent' property will need to be updated.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
6. src/lmnr/sdk/types.py:308
  • Draft comment:
    Removed all agent-specific types (RunAgentRequest, ActionResult, AgentOutput, StepChunkContent, TimeoutChunkContent, FinalOutputChunkContent, ErrorChunkContent, RunAgentResponseChunk). Confirm that no dependencies remain and update documentation accordingly.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the PR author to confirm that no dependencies remain and to update documentation, which violates the rules against asking for confirmation and updating documentation. The comment does not provide a specific code suggestion or point out a specific issue with the code.

Workflow ID: wflow_rP3YZHXr3b6oaSZy

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@dinmukhamedm dinmukhamedm merged commit 09531ce into main Nov 30, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants