refac: Migrate all pipelines db operation to drizzle on NextJs #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dinmukhamedm
left a comment
dinmukhamedm
left a comment
There was a problem hiding this comment.
As a draft this looks good to me overall. Let's go ahead and test this/remove the redundant routes and methods in the backend
|
|
||
| const UpdatePipelineSchema = z.object({ | ||
| name: z.string().optional(), | ||
| visibility: z.enum(['PUBLIC', 'PRIVATE']).optional() |
Member
There was a problem hiding this comment.
I think there is no way to update the "visibility" part from the UI. Let's remove handling it, this is sort of legacy. Sorry, I should have mentioned that in the issue description.
Comment on lines
+293
to
+294
| export const DEFAULT_NEW_PIPELINE_VERSION_ID_STRING = | ||
| 'db6d1708-9836-42f2-a3ea-732ca7709039'; |
Member
There was a problem hiding this comment.
nit, let's rename this to DEFAULT_NEW_PIPELINE_TEMPLATE_ID.
Two small changes:
- clearer communication that this is a template. Yes, I gave the variable the original name and only now I realize how confusing it is.
- no need to call it a string. The only reason it was called a string was an indication in Rust to parse it to UUID. As we don't need to do that in JS, we can drop that part
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closed #140