Skip to content

Add steam API#16

Merged
CaoKha merged 2 commits into
mainfrom
kha
May 13, 2026
Merged

Add steam API#16
CaoKha merged 2 commits into
mainfrom
kha

Conversation

@CaoKha
Copy link
Copy Markdown
Contributor

@CaoKha CaoKha commented May 7, 2026

Summary

  • Add stream/v1 WebSocket client (auth, public, subscription, models).
  • Restructure package: lnmarkets_sdk.rest_v3lnmarkets_sdk.rest.v3.
  • Drop account.withdraw_internal / get_internal_deposits / get_internal_withdrawals (endpoints gone from api-rest-v3) and associated models.
  • Add account.read_notifications()PUT /account/notifications.
  • Rename examples/basic.pyexamples/rest_v3.py; add examples/stream_v1.py.
  • Fix update_takeprofit example: open real isolated market trade instead of hardcoded UUID (was returning 400 You do not own this trade).

Changes

Added

  • stream/v1 package: client, auth, public, subscription, models (announcements, auth, common, cross, futures, isolated, lifecycle, ohlc, subscription, wallet).
  • AccountClient.read_notifications().
  • examples/stream_v1.py.

Changed

  • Package path rest_v3rest/v3.
  • Example basic.pyrest_v3.py; take-profit flow opens real trade.
  • uv.lock, pyproject.toml updated for new deps.

Removed

  • AccountClient.withdraw_internal, get_internal_deposits, get_internal_withdrawals.
  • Models: WithdrawInternalParams, WithdrawInternalResponse, InternalDe GetInternalDepositsParams, GetInternalWithdrawalsParams`.

Test plan

  • uv run examples/rest_v3.py runs clean.
  • uv run examples/stream_v1.py connects, authenticates, receives messages.
  • Integration tests pass: `uv run pytest src/lnmarkets_sdk/rest/v3/test
  • Imports updated downstream: no lnmarkets_sdk.rest_v3 references rem
  • CHANGELOG 0.1.0 accurate.

@CaoKha CaoKha requested a review from vafanassieff May 7, 2026 16:43
@CaoKha CaoKha self-assigned this May 7, 2026
@CaoKha CaoKha added the enhancement New feature or request label May 7, 2026
@CaoKha CaoKha force-pushed the kha branch 9 times, most recently from 9e482d0 to 0a013aa Compare May 13, 2026 12:46
vafanassieff
vafanassieff previously approved these changes May 13, 2026
@vafanassieff vafanassieff changed the title [stream_v1] Add websocket client Add steam API May 13, 2026
@CaoKha CaoKha dismissed vafanassieff’s stale review May 13, 2026 13:00

The merge-base changed after approval.

@CaoKha CaoKha merged commit e714d74 into main May 13, 2026
1 check passed
@CaoKha CaoKha deleted the kha branch May 13, 2026 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants