Skip to content

fix: dynamic instance type selection#57

Merged
motorina0 merged 3 commits intodevfrom
feat/image-select
Mar 20, 2026
Merged

fix: dynamic instance type selection#57
motorina0 merged 3 commits intodevfrom
feat/image-select

Conversation

@dni
Copy link
Member

@dni dni commented Mar 19, 2026

closes #56

screenshot-1773919814

@dni dni requested a review from arcbtc March 19, 2026 11:33
}
}
},
normalizeSelectedInstanceTypeTag(value) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

way too much codex validation and notmalisation here

this.newInstanceDialog.show = true
this.newInstanceDialog.selectedTag = null
this.newInstanceDialog.error = null
if (action === 'on-demand' || action === 'plan-request') {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why check on the action here?

@motorina0 motorina0 merged commit 193e66c into dev Mar 20, 2026
@motorina0 motorina0 deleted the feat/image-select branch March 20, 2026 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: dynamic instance image selector + use GET /instances/types so build the selector

3 participants