Merged
Conversation
Ensures outbound Nostr messages are valid JSON and safely escaped by constructing the payload as Python objects and serializing with json.dumps
176aa98 to
eb05d39
Compare
motorina0
approved these changes
Sep 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: construct EVENT message with
json.dumpsinstead of string interpolationWhy
The old implementation built JSON-like strings by interpolation. This works for simple inputs, but as soon as values contain quotes, backslashes, or Unicode characters, the result is not valid JSON and will be rejected by relays.
Change
Example of the problem
Inputs
Old code
The string looks like JSON but cannot be parsed.
New code
Benefits