Skip to content

Conversation

@dni
Copy link
Member

@dni dni commented Apr 23, 2025

when creating a withdraw link with an improperly configured proxy server a InvalidUrl error was thrown but not handled, resulting in returning a ValueError and an empty error message for clients.

  • refactor to use helpers instead of putting logic in models
  • lnurl_response was unused
  • update poetry.lock

@dni dni requested a review from talvasconcelos April 23, 2025 11:46
@dni dni requested review from arcbtc and motorina0 April 23, 2025 11:55
@motorina0
Copy link
Collaborator

Why take it out of the model?
It is a withdraw link specific functionality and it cannot be used without a withdraw link.

@dni
Copy link
Member Author

dni commented Apr 29, 2025

i think it is better there, it took me a while to find the cause of this issue, it was not obvious for me that a model function had logic in it and was able to throw an exception. i think its makes it more obvious inside the helper and keeps the model simple.

@dni dni merged commit b42fee9 into main Jul 15, 2025
14 checks passed
@dni dni deleted the lnurl_enc_error branch July 15, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants