Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAttention: Patch coverage is
🚀 New features to boost your workflow:
|
src/hssm/hssm.py
Outdated
| # # Need to determine what the output should look like | ||
| # if self.p_outlier.is_regression: | ||
| # raise NotImplementedError( | ||
| # "Regression for `p_outlier` is not implemented yet." | ||
| # ) |
There was a problem hiding this comment.
Keep commented code or ok to delete?
| "z": {"dist": "Weibull", "alpha": 1.2, "beta": 0.25}, | ||
| "t": {"dist": "HalfNormal", "sigma": 0.2}, | ||
| "sv": {"dist": "Weibull", "alpha": 1.5, "beta": "0.3"}, | ||
| "sz": {"dist": "Weibull", "alpha": 1.5, "beta": "0.3"}, | ||
| "st": {"dist": "Weibull", "alpha": 1.5, "beta": "0.3"}, | ||
| "sv": {"dist": "Weibull", "alpha": 1.5, "beta": 0.3}, | ||
| "sz": {"dist": "Weibull", "alpha": 1.5, "beta": 0.3}, | ||
| "st": {"dist": "Weibull", "alpha": 1.5, "beta": 0.3}, | ||
| "p_outlier": {"dist": "Weibull", "alpha": 1.5, "beta": 0.3}, |
There was a problem hiding this comment.
Why the switch to actual number types?
There was a problem hiding this comment.
To be honest I am confused how this became a string before. As far as I am concerned this should have always been float. @cpaniaguam @digicosmos86
digicosmos86
left a comment
digicosmos86
left a comment
There was a problem hiding this comment.
LGTM! I think we also need to change some associated type annotations and for p_outliers in HSSM and other functions to make explicit that we do support regressions for it. It could be another PR though
3 participants
adding in missing defaults for p-outlier regression, and a small associated tutorial.