Conversation
Collaborator
abh3po
commented
Sep 18, 2025
abh3po
commented
- Add Warning for External Users.
- Add Warning for Flash users not in contact
- Auto Add Users as contact on confirm payment screen
abh3po
requested review from
Nodirbek75 and
islandbitcoin
and removed request for
Nodirbek75
Nodirbek75
requested changes
Sep 22, 2025
Contributor
Nodirbek75
left a comment
Nodirbek75
left a comment
There was a problem hiding this comment.
- Contact is currently saved on the details screen, but I think it should only be saved once the payment successfully goes through.
- Next button is not working when I send to external wallet lnurl address
- Getting confirmation modal even I sent to lightning/onchain address
Comment on lines
-7244
to
+7278
| onchainMinAmountInvoiceError: (arg: { amount: number | string }) => LocalizedString | ||
| onchainMinAmountInvoiceError: (arg: { amount: number }) => LocalizedString | ||
| /** | ||
| * The amount on the invoice is less than minimum amount {amount} | ||
| */ | ||
| minAmountInvoiceError: (arg: { amount: number | string }) => LocalizedString | ||
| minAmountInvoiceError: (arg: { amount: number }) => LocalizedString | ||
| /** | ||
| * The amount on the invoice is greater than maximum amount {amount} | ||
| */ | ||
| maxAmountInvoiceError: (arg: { amount: number | string }) => LocalizedString | ||
| maxAmountInvoiceError: (arg: { amount: number }) => LocalizedString | ||
| /** | ||
| * The conversion amount is less than minimum required amount {amount} | ||
| */ | ||
| minAmountConvertError: (arg: { amount: number | string }) => LocalizedString | ||
| minAmountConvertError: (arg: { amount: number }) => LocalizedString | ||
| /** | ||
| * The conversion amount is greater than maximum amount {amount} | ||
| */ | ||
| maxAmountConvertError: (arg: { amount: number | string }) => LocalizedString | ||
| maxAmountConvertError: (arg: { amount: number }) => LocalizedString |
Contributor
There was a problem hiding this comment.
Need to put back string type
abh3po
force-pushed
the
auto-add-contacts
branch
from
40b5550 to
5b2a0d0
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Nodirbek75
requested changes
Oct 21, 2025
Contributor
Nodirbek75
left a comment
Nodirbek75
left a comment
There was a problem hiding this comment.
Confirm destination modal is not popping up. getContactPubkeys method returning null.
Nodirbek75
approved these changes
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.