Skip to content

Quck zap on messages#608

Merged
abh3po merged 2 commits intomainfrom
zap-message
Apr 14, 2026
Merged

Quck zap on messages#608
abh3po merged 2 commits intomainfrom
zap-message

Conversation

@abh3po
Copy link
Copy Markdown
Collaborator

@abh3po abh3po commented Apr 9, 2026

image

Copy link
Copy Markdown
Contributor

@islandbitcoin islandbitcoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was getting an error, and AI added a commit ed9e6ee to fix the URL.

@abh3po please confirm this is correct, it works with the commit

@islandbitcoin
Copy link
Copy Markdown
Contributor

I feel like the commit that vandana made could be tigher, instead of just a condition to patch the URL.
@abh3po please review

@abh3po
Copy link
Copy Markdown
Collaborator Author

abh3po commented Apr 11, 2026

Seems correct, code wise, would just want to test with flash users and external users both to be more confident with it.

What was the error about?

@islandbitcoin
Copy link
Copy Markdown
Contributor

Seems correct, code wise, would just want to test with flash users and external users both to be more confident with it.

What was the error about?

basically wrong callback URL error

@abh3po
Copy link
Copy Markdown
Collaborator Author

abh3po commented Apr 14, 2026

basically wrong callback URL error

@islandbitcoin it was not wrong, that is the callback for flash users there was just no need for flash users to be handled any differently if we know that they're going to have npubs and a lud16 in their profiles. I was just trying to be extra smart and trying to solve for the 0.0001% case where this might not be true

@abh3po abh3po merged commit 940806b into main Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants