fix: bridge manual external account fallback#652
Merged
islandbitcoin merged 4 commits intoJun 28, 2026
Conversation
Use navigation.replace instead of navigate after successful external account creation so the manual form is removed from the stack — pressing back from CashoutDetails returns to TopupCashout, not the form. Also handle the duplicate-submission case: if the user re-enters the same account details and Bridge returns an error, treat it as 'already linked' and proceed to cashout instead of showing a 400.
The local bank transfer screen had hardcoded Flash banking details (BBW/Banco Hipotecario). These should come from ERPNext dynamically with a per-user reference code — tracked as part of TopUp V1 in Linear. Until that's built, show a message directing users to contact support via WhatsApp for banking information.
islandbitcoin
added a commit
that referenced
this pull request
Jun 28, 2026
* fix(bridge): prevent back-stack trap after manual bank link Use navigation.replace instead of navigate after successful external account creation so the manual form is removed from the stack — pressing back from CashoutDetails returns to TopupCashout, not the form. Also handle the duplicate-submission case: if the user re-enters the same account details and Bridge returns an error, treat it as 'already linked' and proceed to cashout instead of showing a 400. * fix(topup): replace hardcoded bank details with WhatsApp support CTA The local bank transfer screen had hardcoded Flash banking details (BBW/Banco Hipotecario). These should come from ERPNext dynamically with a per-user reference code — tracked as part of TopUp V1 in Linear. Until that's built, show a message directing users to contact support via WhatsApp for banking information. * fix(topup): skip amount entry for disabled bank transfer * fix(topup): polish WhatsApp support CTA * test(send-confirmation): fix flaky fee-display assertion The realtimePrice mock typed me.defaultAccount as the "Account" interface while every other mock uses the concrete "ConsumerAccount". This normalized to a separate Apollo cache entity, so whichever query wrote me.defaultAccount last won; when a ConsumerAccount query (no realtimePrice field) resolved after realtimePrice, the display currency reverted to USD and the fee's display-currency amount rendered empty. Aligning the __typename makes realtimePrice persist regardless of resolution order, so SendScreen Confirmation settles deterministically. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
islandbitcoin
pushed a commit
that referenced
this pull request
Jul 2, 2026
Conflict in BridgeAddExternalAccount.tsx: #652 switched the post-link navigation to navigation.replace (back must not return to the form) and added an already-linked path (BRIDGE_API_ERROR treated as success); this branch added the returnTo=BankAccounts entry point and i18n. Resolved by extracting a single navigateAfterLink helper used by both the success and already-linked alerts: returnTo=BankAccounts navigates back to the existing hub instance (drops the form from the stack), otherwise replace to CashoutDetails per #652. The already-linked path now also respects returnTo, so adding a duplicate bank from Settings returns to Settings instead of dropping into the cash-out flow. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
islandbitcoin
pushed a commit
that referenced
this pull request
Jul 2, 2026
- extract the #652 already-linked alert strings to i18n (BridgeAddExternalAccount.alreadyLinkedTitle/Message) - toast confirmation when a default withdrawal account is set in the hub (no feedback before beyond the radio moving) - CashoutWithdrawTo: reload the stored default on screen focus instead of mount only, so a default changed in Settings is reflected when returning to an already-mounted cash-out screen - promote serverDefault to a proper optional field on BankAccountVM instead of smuggling it through type casts Verified: tsc:check clean, eslint clean on touched files, jest 36 suites / 159 tests green on the merged tree. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
islandbitcoin
pushed a commit
that referenced
this pull request
Jul 2, 2026
* feat(bridge): show virtual account details in settings * feat(bridge): scaffold unified Bank accounts hub (money-in + money-out) Introduce a single "Bank accounts" settings surface that unifies the Bridge virtual (receive) account and the user's withdrawal banks behind one rail-agnostic view model, replacing the standalone routing-number row. - add normalized BankAccountVM + useBankAccounts() hook merging bridgeVirtualAccount (receive), bridgeExternalAccounts (USD withdraw) and me.bankAccounts (local withdraw), with per-currency default resolution - add BankAccountsScreen: Receive card (reveal/copy, KYC-gated) + currency grouped Withdraw list with default selection, status pills and add flow - interim client-side default store (AsyncStorage) until backend adds isDefault + bridgeSetDefaultExternalAccount (kept isolated from the persistentState migration chain for a one-file swap later) - wire BankAccounts route + settings row; hub handles KYC state internally Scaffolding only: set-default persists client-side; remove is gated on a future bridgeDeleteExternalAccount mutation. tsc + eslint clean. * feat(bridge): cancel button on add-account + WhatsApp support link - Add Cancel button in the Add Bank Account header (navigation.goBack) - Add Contact Support button at the bottom of the Bank accounts hub that opens WhatsApp support (wa.flashapp.me) via openWhatsAppUrl * feat(bridge): add Upgrade button to locked Bank accounts card KYC-not-approved state now shows an Upgrade your account button that navigates to the AccountType upgrade flow — same destination as the QuickStart upgrade card on the Home screen. * feat(bridge): finish Bank accounts follow-ups * fix(bridge): allow Bank accounts screen to scroll * polish(bank-accounts): i18n already-linked alert + small UX fixes - extract the #652 already-linked alert strings to i18n (BridgeAddExternalAccount.alreadyLinkedTitle/Message) - toast confirmation when a default withdrawal account is set in the hub (no feedback before beyond the radio moving) - CashoutWithdrawTo: reload the stored default on screen focus instead of mount only, so a default changed in Settings is reflected when returning to an already-mounted cash-out screen - promote serverDefault to a proper optional field on BankAccountVM instead of smuggling it through type casts Verified: tsc:check clean, eslint clean on touched files, jest 36 suites / 159 tests green on the merged tree. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * chore(i18n): backfill Bank accounts keys into all locale files The translation-drift check (added in #604) requires every locale to contain all en.json keys. Backfill the 72 new Bank accounts / add-bank keys into all 23 locale files with English placeholder values — same interim convention as existing untranslated keys (e.g. Cashout section). Proper translations can follow the ENG-242 machine-translate process. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Patoo <262265744+patoo0x@users.noreply.github.com> Co-authored-by: Dread <dread@example.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.