Parameterize frappe image tag and add local compose override#279
Merged
Conversation
Replace hardcoded brh28/frappe-flash:0.0.4 with ${FRAPPE_TAG:-latest}
so developers can pin versions via env var. Add docker-compose.local.yml
for personal overrides (e.g. bind mounting local frappe-flash-admin) and
wire it into COMPOSE_FILE in .env.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default, erpnext should run with the latest version of
frappe-flash. However, a developer can bind the docker volume to their host to make developer changes to thefrappe-flash-adminrepoReplace hardcoded brh28/frappe-flash:0.0.4 with ${FRAPPE_TAG:-latest} so developers can pin versions via env var. Add docker-compose.local.yml for personal overrides (e.g. bind mounting local frappe-flash-admin) and wire it into COMPOSE_FILE in .env.