Merged
Conversation
- Rewrite DEV.md with clearer quick-start, architecture overview, troubleshooting section, and useful commands reference - Add dev/setup.sh — interactive script that validates prerequisites, configures Ibex credentials, installs deps, and starts Docker - Fix package.json engine spec: '20' → '>=20.18.1 <21' (cheerio requires >=20.18.1, bare '20' matched 20.10.0 which fails)
- Add troubleshooting entry for price service amd64 platform warning on ARM Macs - Add IBEX_URL, IBEX_EMAIL, IBEX_PASSWORD defaults to .env to suppress docker compose warnings about unset variables
brh28
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Improves the developer onboarding experience for new contributors setting up the Flash backend locally.
Changes
1.
DEV.md— Complete rewriteUnauthorizedError(use oathkeeper proxy, not direct port)2.
dev/setup.sh— New interactive setup script.env.localdev-overrides.yamlautomatically3.
package.json— Fix engine spec"node": "20"→"node": ">=20.18.1 <21"cheerio@1.1.2dependency requires>=20.18.1, so20.10.0fails onyarn install"20"spec was too loose — it matched Node 20.10.0 which then broke on transitive depsIssues Found During Setup
"node": "20"in package.json matches any 20.x, but cheerio needs >=20.18.1 → confusing error for devs using 20.10.0Testing
./dev/setup.sh, thenmake start— server started and responded on all endpoints