Skip to content

Feat : Cashout notification#297

Open
heyolaniran wants to merge 1 commit intolnflash:mainfrom
heyolaniran:feature/payment-entry-notification
Open

Feat : Cashout notification#297
heyolaniran wants to merge 1 commit intolnflash:mainfrom
heyolaniran:feature/payment-entry-notification

Conversation

@heyolaniran
Copy link

@heyolaniran heyolaniran commented Mar 18, 2026 •
edited
Loading

feature : Cashout Notifiction from Admin

In this PR i've added :

  • Graph QL mutation that resolves the cashout (payment entry) notification from Admin action in file
  • At App Layer, this commit added the send cashout notification for cashout settled on Galoy Payments notification type and delegate the notification action to admin push notification filtered send from the notification service
  • Unit test for cashout notification in test flash unit directory.

🧪 Testing Coverage

  • Unit Tests: Describe tested components or logic
  • Integration Tests: State management or system interaction
  • Manual Testing: End-to-end user journey or QA notes

📚 Documentation Updates

  • Rewards System Guide (if applicable)
  • Environment Configuration (.env or build setup)
  • Security Guidelines or internal protocol updates

🔄 Future Phases

This PR delivers Phase X of Y.
Next:

  • Time-based controls / analytics
  • Tiered rewards
  • Push notifications / reporting

Branch:
Reviewer Notes:
Deployment Instructions:

@heyolaniran heyolaniran force-pushed the feature/payment-entry-notification branch 3 times, most recently from 9df24f1 to 1680dc7 Compare March 18, 2026 14:07
brh28
brh28 reviewed Mar 19, 2026
View reviewed changes
Copy link
Contributor

@brh28 brh28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. When we jump on the call this morning, I want to look into that sendAdminPushNotification function that's being used, since Dread mentioned we should start moving away from the Galoy notification code

@heyolaniran heyolaniran force-pushed the feature/payment-entry-notification branch from 1680dc7 to 68ace26 Compare March 20, 2026 17:17
brh28
brh28 requested changes Mar 20, 2026
View reviewed changes
Copy link
Contributor

@brh28 brh28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, if you make a change to the graphql schema, you should run make codegen to generate the updated schema

@heyolaniran heyolaniran force-pushed the feature/payment-entry-notification branch from 68ace26 to 89bc2f9 Compare March 20, 2026 23:33
@heyolaniran heyolaniran mentioned this pull request Mar 22, 2026
Merged
@heyolaniran heyolaniran requested a review from brh28 March 22, 2026 21:15
@heyolaniran heyolaniran force-pushed the feature/payment-entry-notification branch 2 times, most recently from 1f94af6 to 32cad63 Compare March 22, 2026 22:18
heyolaniran
heyolaniran commented Mar 23, 2026
View reviewed changes
heyolaniran
heyolaniran commented Mar 23, 2026
View reviewed changes
@heyolaniran heyolaniran force-pushed the feature/payment-entry-notification branch 4 times, most recently from d25e170 to 1a52ff9 Compare March 24, 2026 17:12
brh28
brh28 reviewed Mar 25, 2026
View reviewed changes
Copy link
Contributor

@brh28 brh28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, but otherwise looks good to merge

@heyolaniran heyolaniran force-pushed the feature/payment-entry-notification branch from 1a52ff9 to 27b7a21 Compare March 25, 2026 13:49
@heyolaniran
Copy link
Author

heyolaniran commented Mar 25, 2026

One comment, but otherwise looks good to merge

Fixed

@brh28
Copy link
Contributor

brh28 commented Mar 25, 2026

I was actually premature with that comment. It looks sendCashoutNotification is still an unused function, and still don't like the sendAdminPushNotification naming. I'm going to make a quick PR into your branch with some changes I have in mind

@heyolaniran
Copy link
Author

heyolaniran commented Mar 25, 2026

I was actually premature with that comment. It looks sendCashoutNotification is still an unused function, and still don't like the sendAdminPushNotification naming. I'm going to make a quick PR into your branch with some changes I have in mind

Yeah I didn't use the implemented sendCashoutNotification on the App layer, I taught the sendAdminPushNotification was more reliable in the code base.

If you don't mind you can continue to get a review about the changes you want to make and then i will apply them.Thanks

@heyolaniran heyolaniran force-pushed the feature/payment-entry-notification branch 2 times, most recently from 4e4f33c to 553e0f8 Compare March 25, 2026 22:05
brh28
brh28 reviewed Mar 26, 2026
View reviewed changes
@heyolaniran heyolaniran force-pushed the feature/payment-entry-notification branch 2 times, most recently from 4bba89a to bb5b687 Compare March 26, 2026 13:54
brh28
brh28 reviewed Mar 26, 2026
View reviewed changes
@heyolaniran heyolaniran force-pushed the feature/payment-entry-notification branch from bb5b687 to 0d9f01c Compare March 26, 2026 15:41
@heyolaniran
Cashout Notification
7dde1c1 
feat: Cashout Settled Notification
In this commit  i've added :
- Graph QL  mutation that resolves the cashout (payment entry) notification from Admin action
- At App Layer, this commit added the send cashout notification for cashout settled on Galoy Payments notification type and delegate the notification action to admin push notification filtered send from the notification service
- Unit test for cashout notification in test flash unit directory. all unit tests passed
End to End test notification push made and passed
- GraphQL schema updated
- Custom Flash Notification Category

Flash Notification Categories
- Notification title in en-local

notification format

fix: cashout notification body format

fix: remove the firebase key path

fix: remove notificationCategory from the Cashout resolver

fix: rebuild graphql schema and update bruno cashout endpoint

fix: notification title

fix: rm duplicated .env.local from gitignore

 rebuild the graphql schema
@heyolaniran heyolaniran force-pushed the feature/payment-entry-notification branch from 0d9f01c to 7dde1c1 Compare March 26, 2026 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brh28 brh28 brh28 requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@heyolaniran @brh28