fix(build): Include asPaymentAmount#335
Merged
brh28 merged 7 commits intolnflash:mainfrom Apr 27, 2026
Merged
Conversation
feat: Cashout Settled Notification In this commit i've added : - Graph QL mutation that resolves the cashout (payment entry) notification from Admin action - At App Layer, this commit added the send cashout notification for cashout settled on Galoy Payments notification type and delegate the notification action to admin push notification filtered send from the notification service - Unit test for cashout notification in test flash unit directory. all unit tests passed End to End test notification push made and passed - GraphQL schema updated - Custom Flash Notification Category Flash Notification Categories - Notification title in en-local notification format fix: cashout notification body format fix: remove the firebase key path fix: remove notificationCategory from the Cashout resolver fix: rebuild graphql schema and update bruno cashout endpoint fix: notification title fix: rm duplicated .env.local from gitignore rebuild the graphql schema fix: not log credentials
brh28
requested changes
Apr 27, 2026
| asPaymentAmount(): Amount<WalletCurrency> { | ||
| return { | ||
| currency: this.currencyCode, | ||
| amount: this.money.toSource() / PRECISION_M, |
Contributor
There was a problem hiding this comment.
what is PRECISION_M? Can we add a unit test to show this working as expected?
Contributor
Author
There was a problem hiding this comment.
it is a defined internal scaling factor in bigint-money , it helps us to store every amount as a big Int multiplied by PRECISION_M to avoid all floating issue.
toSource() Returns the underlying bigint value.
This is the current value of the object, multiplied by 10 ** 12 (PRECISION_M).
So if we need the amount back in cents, we have do divide again by PRECISION_M
…e USDAmount and JMDAmount can use it
Contributor
Author
|
@brh28 there is a test you can run in |
Contributor
|
Contributor
Author
brh28
changed the title
asPaymentAmount
brh28
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this Pr add the
asPaymentAmountto the USDAmount. @brh28 @islandbitcoin