fix: route lightning address payments to the user's default wallet#357
Merged
islandbitcoin merged 1 commit intoMay 18, 2026
Merged
Conversation
listByAccountId returns wallets in undefined order, causing wallet[0] to resolve to a random wallet's lnurlp. Use the account's defaultWalletId to honour whichever wallet the user has designated as default, whether that is the BTC, USD, or external wallet.
heyolaniran
force-pushed
the
feature/external-wallet-lnurl
branch
from
6e7fe9f to
720c275
Compare
brh28
approved these changes
May 18, 2026
islandbitcoin
added a commit
that referenced
this pull request
May 21, 2026
* fix: resolve breaking changes to BankAccount * fix: route lightning address payments to the user's default wallet (#357) --------- Co-authored-by: Benjamin Hindman <bhindman@proton.me> Co-authored-by: Olaniran ⚡ <93789719+heyolaniran@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
listByAccountId returns wallets in undefined order, causing wallet[0] to resolve to a random wallet's lnurlp. Use the account's defaultWalletId to honour whichever wallet the user has designated as default, whether that is the BTC, USD, or external wallet.