feat(proto): upgrade price.proto float to double for multi-currency precision#366
Open
onchito-walks wants to merge 1 commit into
Open
feat(proto): upgrade price.proto float to double for multi-currency precision#366onchito-walks wants to merge 1 commit into
onchito-walks wants to merge 1 commit into
Conversation
…recision Changes PriceResponse.price from float (32-bit, ~7 sig figs) to double (64-bit, ~15 sig figs) to avoid silent truncation of JMD and other non-USD fiat exchange rates that need >7 significant digits. Wire-compatible: protobuf handles float->double conversion transparently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change:
PriceResponse.price→float→doubleinprice.protoWhy: 32-bit float (~7 significant digits) silently truncates exchange rates for JMD and other non-USD fiat currencies that need more precision.
Impact: Protobuf handles float→double conversion transparently. Existing servers that send float are decoded as double with zero precision loss. The price server can be updated independently.
Verification:
yarn tsc-check— protobuf wire format change only.1 file changed, 1 insertion, 1 deletion. Wire-compatible.