Conversation
Without this change, cppcheck would accuse that target_reg was uninitialized when used, even though a reference had been captured, and the lambda was only called after it was initialized. We can reorder the code so this false-positive isn't triggered, and without accidentally suppresing any warnings from other tools (as might have happened if we had initialized target_reg to nullptr).
Use a matrix with jobs in order to parallelize running different tools,
even though for now we are only using cppcheck.
We ignore some files with cppcheck due to issues with Catch2. An example
of an error generated by cppcheck with Catch2:
util/tests/bits-test.cc:36:5: error: There is an unknown macro here
somewhere. Configuration is required. If _catch_sr is a macro then
please configure it. [unknownMacro]
CHECK_THROWS_AS(clear_and_insert(reg, 1000U, range_mask), std::runtime_error);
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the less complicated part of #60 so we can merge it more quickly.