COMMISS.FOFB.ENH: use largest amp possible.#267
Merged
Conversation
ericonr
commented
Mar 5, 2024
juliacscarvalho
approved these changes
Mar 12, 2024
guilhermerc
reviewed
Mar 12, 2024
If we scale the singular vectors used for closed loop identification starting from the largest amplitude possible for the last mode, we can try and guarantee the best possible SNR for all modes. This makes it necessary to change the ampmin argument to ampmax.
By definition, the singular vectors are normalized, but the magnitude of their members will vary, depending on how "spread out" they are spacially. Therefore, scaling the singular vectors by their greatest member adds an arbitrary scaling factor and breaks the relationship between control effort and singular vector.
fernandohds564
approved these changes
Mar 18, 2024
guilhermerc
approved these changes
Mar 18, 2024
juliacscarvalho
approved these changes
Mar 19, 2024
anacso17
approved these changes
Mar 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we scale the singular vectors used for closed loop identification starting from the largest amplitude possible for the last mode, we can try and guarantee the best possible SNR for all modes. It then becomes necessary to add an ampmax argument as well.