Skip to content

Sysid updates#272

Merged
juliacscarvalho merged 8 commits intomasterfrom
sysid_updates
Jun 14, 2024
Merged

Sysid updates#272
juliacscarvalho merged 8 commits intomasterfrom
sysid_updates

Conversation

@juliacscarvalho
Copy link
Copy Markdown
Contributor

@juliacscarvalho juliacscarvalho commented May 24, 2024 •
edited
Loading

This PR:

  • Corrects the BPM positions to be saved according to the beam ordenation;
  • Adds the PRBS maximum levels as a FOFBSysIdAcqParams attribute;
  • Changes the levels functions to get one or two levels as parameter, as the second one is usually set as the opposite of the first one.

fernandohds564
fernandohds564 requested changes May 24, 2024
View reviewed changes
@juliacscarvalho
Update meas_fofb_sysid.py
7a5b982 
Add svd_levels_ampmax to __str__ method
@juliacscarvalho
Update meas_fofb_sysid.py
b166771 
Fixing linting issues.
ericonr
ericonr requested changes Jun 12, 2024
View reviewed changes
@juliacscarvalho
Update meas_fofb_sysid.py
1265184 
Update saved dictionary
@juliacscarvalho juliacscarvalho merged commit c2f1fe7 into master Jun 14, 2024
@fernandohds564
Copy link
Copy Markdown
Contributor

fernandohds564 commented Jun 14, 2024 •
edited
Loading

@juliacscarvalho, we generally delete merged branches. I'll delete this one, ok?

@fernandohds564 fernandohds564 deleted the sysid_updates branch June 14, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fernandohds564 fernandohds564 fernandohds564 approved these changes

@ericonr ericonr ericonr approved these changes

@anacso17 anacso17 Awaiting requested review from anacso17

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@juliacscarvalho @fernandohds564 @ericonr