Add LINAC knobs for injection optimization#291
Merged
Conversation
vellosok75
changed the title
murilobalves
approved these changes
Jan 15, 2025
xresende
approved these changes
Jan 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR adds LINAC knobs (lenses, solenoids, quadrupoles, klystrons and sub-harmonic buncher) to the Booster Injection Optimization Class. It also changes the optimization module base class to allow the positions of optimization routines to be at the upper/lower limits of knobs space. Before these changes, positions at the limits (but not exceeding them) were being judged as "inconsistent" by the checking routine.
Optimization with lenses, solenoids and quadrupoles has been tested online during the machine study shift of Jan. 7th, as reported here.